LayoutTests/fast/forms/checkValidity-005.html - Issue 246883004: Fix checkValidity for form containing menulist select

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/checkValidity-005.html

Issue 246883004: Fix checkValidity for form containing menulist select (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>
	tkent 2014/04/23 07:37:35 The test file name is bad. -005 is meaningless. The test file name is bad. -005 is meaningless. gnana 2014/04/23 14:10:04 Done. Show quoted text On 2014/04/23 07:37:35, tkent wrote: > The test file name is bad. -005 is meaningless. Done.
	2 <body>

	3 <script src="../../resources/js-test.js"></script>

	4 <form action="">

	5 <select required="">

	6 <option>abc</option>

	7 </select>

	8 </form>

	9 <script>

	10 description("This test checks if checkValidity() returns correctly a true result on selecting a valid element.");

	11 jsTestIsAsync = true;

	12 var form = document.querySelector('form');

	13 var select = document.querySelector('select');

	14 window.onload = function(){
	tkent 2014/04/23 07:37:35 White space usage in this code is very inconsisten White space usage in this code is very inconsistent. gnana 2014/04/23 14:10:04 Done. Show quoted text On 2014/04/23 07:37:35, tkent wrote: > White space usage in this code is very inconsistent. Done.
	15 select.value = null;

	16 form.addEventListener('change', function(){

	17 shouldBeTrue('form.checkValidity()');

	18 finishJSTest();

	19 });

	20 select.focus();

	21 if (window.eventSender)

	22 eventSender.keyDown('downArrow');
	tkent 2014/04/23 07:37:35 I think this won't work on Mac. .keyDown('a') wou I think this won't work on Mac. .keyDown('a') would work. gnana 2014/04/23 14:10:04 Done. Show quoted text On 2014/04/23 07:37:35, tkent wrote: > I think this won't work on Mac. .keyDown('a') would work. Done.
	23 };

	24 </script>

	25 </body>

	26 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/forms/checkValidity-005-expected.txt » ('j') | no next file with comments »