Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Unified Diff: Source/core/html/HTMLSelectElement.cpp

Issue 246883004: Fix checkValidity for form containing menulist select (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: incorporated review comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/forms/checkValidity-select-form-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLSelectElement.cpp
diff --git a/Source/core/html/HTMLSelectElement.cpp b/Source/core/html/HTMLSelectElement.cpp
index 3d6008f59fb17047e01b10a2f9a1d833350ff29d..883df3c2263d17e6b85a3e8aa1ff34970d4be5f5 100644
--- a/Source/core/html/HTMLSelectElement.cpp
+++ b/Source/core/html/HTMLSelectElement.cpp
@@ -902,6 +902,8 @@ void HTMLSelectElement::selectOption(int optionIndex, SelectOptionFlags flags)
scrollToSelection();
+ setNeedsValidityCheck();
+
if (usesMenuList()) {
m_isProcessingUserDrivenChange = flags & UserDriven;
if (flags & DispatchInputAndChangeEvent)
@@ -914,7 +916,6 @@ void HTMLSelectElement::selectOption(int optionIndex, SelectOptionFlags flags)
}
}
- setNeedsValidityCheck();
notifyFormStateChanged();
}
« no previous file with comments | « LayoutTests/fast/forms/checkValidity-select-form-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698