Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2467933002: [DevTools] migrate InspectorPageAgent and InspectorMemoryAgent to new style (Closed)

Created:
4 years, 1 month ago by kozy
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] migrate InspectorPageAgent and InspectorMemoryAgent to new style BUG=none R=dgozman@chromium.org Committed: https://crrev.com/905e2b51c2deaf3597f3e296e6d983ab6b76d676 Cr-Commit-Position: refs/heads/master@{#429232}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -107 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorMemoryAgent.h View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorMemoryAgent.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.h View 2 chunks +24 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 16 chunks +58 lines, -63 lines 0 comments Download
M third_party/inspector_protocol/CodeGenerator.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/inspector_protocol/README.chromium View 1 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 2466963002 Patch 40001

Dependent Patchsets:

Issue 2463293002 Patch 20001

Messages

Total messages: 12 (6 generated)
kozy
Dmitry, please take a look.
4 years, 1 month ago (2016-11-01 15:56:40 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2467933002/diff/1/third_party/inspector_protocol/templates/TypeBuilder_cpp.template File third_party/inspector_protocol/templates/TypeBuilder_cpp.template (right): https://codereview.chromium.org/2467933002/diff/1/third_party/inspector_protocol/templates/TypeBuilder_cpp.template#newcode372 third_party/inspector_protocol/templates/TypeBuilder_cpp.template:372: std::move(in_{{property.name}}) Ain't this already in original patch? If ...
4 years, 1 month ago (2016-11-01 18:39:28 UTC) #3
kozy
Thanks. https://codereview.chromium.org/2467933002/diff/1/third_party/inspector_protocol/templates/TypeBuilder_cpp.template File third_party/inspector_protocol/templates/TypeBuilder_cpp.template (right): https://codereview.chromium.org/2467933002/diff/1/third_party/inspector_protocol/templates/TypeBuilder_cpp.template#newcode372 third_party/inspector_protocol/templates/TypeBuilder_cpp.template:372: std::move(in_{{property.name}}) On 2016/11/01 18:39:27, dgozman wrote: > Ain't ...
4 years, 1 month ago (2016-11-02 04:19:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467933002/20001
4 years, 1 month ago (2016-11-02 06:16:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 07:52:55 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 07:56:43 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/905e2b51c2deaf3597f3e296e6d983ab6b76d676
Cr-Commit-Position: refs/heads/master@{#429232}

Powered by Google App Engine
This is Rietveld 408576698