[DevTools] migrate NetworkAgent to new style

[DevTools] migrate NetworkAgent to new style

Replace in header:
void ([a-zA-Z]+)\(\s*ErrorString\*(?: error(?:String)?)?,? ?
Response \1(

Replace in implementation:
void ([a-zA-Z]+)::([a-zA-Z]+)\(\s*ErrorString\*(?: error(?:String)?)?,? ?
Response \1::\2(

Replace in header and implementation:
const (?:protocol::)?Maybe<([^>]+)>&
Maybe<\1>

Remove in implementation:
&error,? ?

Replace in implementation:
\*error(?:String)? = ("[^"]+");\s+return;
return Response::Error(\1);

Replace in implementation:
sendFailure\(("[^"]+")\)
sendFailure(Response::Error(\1))

Added return Response::OK at the end of functions.

BUG=none
R=dgozman@chromium.org

Committed: https://crrev.com/f94799b234e478daa578dd91458b6908a758dfb6
Cr-Commit-Position: refs/heads/master@{#429214}

[kozy, 2016-11-01 18:00:35]

Dmitry, please take a look.

[dgozman, 2016-11-01 18:42:02]

lgtm

https://codereview.chromium.org/2466963002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp (right):

https://codereview.chromium.org/2466963002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp:1167: return
Response::Error("Invalid characters found in userAgent");
Keep {}

https://codereview.chromium.org/2466963002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp:1292: return
Response::OK();
Error("Given id does not correspond to XHR")

https://codereview.chromium.org/2466963002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp:1297: return
Response::OK();
Error("Document is already detached")

[kozy, 2016-11-02 04:13:30]

All done.

https://codereview.chromium.org/2466963002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp (right):

https://codereview.chromium.org/2466963002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp:1167: return
Response::Error("Invalid characters found in userAgent");
On 2016/11/01 18:42:02, dgozman wrote:
> Keep {}

Done.

https://codereview.chromium.org/2466963002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp:1292: return
Response::OK();
On 2016/11/01 18:42:02, dgozman wrote:
> Error("Given id does not correspond to XHR")

Done.

https://codereview.chromium.org/2466963002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp:1297: return
Response::OK();
On 2016/11/01 18:42:02, dgozman wrote:
> Error("Document is already detached")

Done.

[kozy, 2016-11-02 04:13:53]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-11-02 04:13:53]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2466963002/#ps40001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-11-02 04:14:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 05:31:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-02 05:33:21]

Description was changed from

==========
[DevTools] migrate NetworkAgent to new style

Replace in header:
void ([a-zA-Z]+)\(\s*ErrorString\*(?: error(?:String)?)?,? ?
Response \1(

Replace in implementation:
void ([a-zA-Z]+)::([a-zA-Z]+)\(\s*ErrorString\*(?: error(?:String)?)?,? ?
Response \1::\2(

Replace in header and implementation:
const (?:protocol::)?Maybe<([^>]+)>&
Maybe<\1>

Remove in implementation:
&error,? ?

Replace in implementation:
\*error(?:String)? = ("[^"]+");\s+return;
return Response::Error(\1);

Replace in implementation:
sendFailure\(("[^"]+")\)
sendFailure(Response::Error(\1))

Added return Response::OK at the end of functions.

BUG=none
R=dgozman@chromium.org
==========

to

==========
[DevTools] migrate NetworkAgent to new style

Replace in header:
void ([a-zA-Z]+)\(\s*ErrorString\*(?: error(?:String)?)?,? ?
Response \1(

Replace in implementation:
void ([a-zA-Z]+)::([a-zA-Z]+)\(\s*ErrorString\*(?: error(?:String)?)?,? ?
Response \1::\2(

Replace in header and implementation:
const (?:protocol::)?Maybe<([^>]+)>&
Maybe<\1>

Remove in implementation:
&error,? ?

Replace in implementation:
\*error(?:String)? = ("[^"]+");\s+return;
return Response::Error(\1);

Replace in implementation:
sendFailure\(("[^"]+")\)
sendFailure(Response::Error(\1))

Added return Response::OK at the end of functions.

BUG=none
R=dgozman@chromium.org

Committed: https://crrev.com/f94799b234e478daa578dd91458b6908a758dfb6
Cr-Commit-Position: refs/heads/master@{#429214}
==========

[commit-bot: I haz the power, 2016-11-02 05:33:22]

Patchset 3 (id:??) landed as
https://crrev.com/f94799b234e478daa578dd91458b6908a758dfb6
Cr-Commit-Position: refs/heads/master@{#429214}