Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2467353003: Remove pageLogicalHeightChanged() from LayoutState. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove pageLogicalHeightChanged() from LayoutState. It was only used from insertFloatingObject(), and in a bogus manner at that. Added a TODO instead. We haven't even positioned the float at this point, so attempting layout for pagination here is essentially bad. We make sure to relayout correctly for pagination when we get to positionNewFloats() later, anyway. Committed: https://crrev.com/78b7de043288de59a3fd7d741c4a1061fc601029 Cr-Commit-Position: refs/heads/master@{#429533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -34 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutState.h View 3 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutState.cpp View 5 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.h View 2 chunks +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
mstensho (USE GERRIT)
4 years, 1 month ago (2016-11-02 22:47:14 UTC) #4
szager1
lgtm
4 years, 1 month ago (2016-11-03 01:18:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467353003/1
4 years, 1 month ago (2016-11-03 06:02:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 06:07:46 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 06:10:57 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78b7de043288de59a3fd7d741c4a1061fc601029
Cr-Commit-Position: refs/heads/master@{#429533}

Powered by Google App Engine
This is Rietveld 408576698