Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 2467353003: Remove pageLogicalHeightChanged() from LayoutState. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutView.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc.
4 * All rights reserved. 4 * All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 83
84 } // namespace 84 } // namespace
85 85
86 LayoutView::LayoutView(Document* document) 86 LayoutView::LayoutView(Document* document)
87 : LayoutBlockFlow(document), 87 : LayoutBlockFlow(document),
88 m_frameView(document->view()), 88 m_frameView(document->view()),
89 m_selectionStart(nullptr), 89 m_selectionStart(nullptr),
90 m_selectionEnd(nullptr), 90 m_selectionEnd(nullptr),
91 m_selectionStartPos(-1), 91 m_selectionStartPos(-1),
92 m_selectionEndPos(-1), 92 m_selectionEndPos(-1),
93 m_pageLogicalHeightChanged(false),
94 m_layoutState(nullptr), 93 m_layoutState(nullptr),
95 m_layoutQuoteHead(nullptr), 94 m_layoutQuoteHead(nullptr),
96 m_layoutCounterCount(0), 95 m_layoutCounterCount(0),
97 m_hitTestCount(0), 96 m_hitTestCount(0),
98 m_hitTestCacheHits(0), 97 m_hitTestCacheHits(0),
99 m_hitTestCache(HitTestCache::create()) { 98 m_hitTestCache(HitTestCache::create()) {
100 // init LayoutObject attributes 99 // init LayoutObject attributes
101 setInline(false); 100 setInline(false);
102 101
103 m_minPreferredLogicalWidth = LayoutUnit(); 102 m_minPreferredLogicalWidth = LayoutUnit();
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 if (document().svgExtensions()) 270 if (document().svgExtensions())
272 document() 271 document()
273 .accessSVGExtensions() 272 .accessSVGExtensions()
274 .invalidateSVGRootsWithRelativeLengthDescendents(&layoutScope); 273 .invalidateSVGRootsWithRelativeLengthDescendents(&layoutScope);
275 } 274 }
276 275
277 ASSERT(!m_layoutState); 276 ASSERT(!m_layoutState);
278 if (!needsLayout()) 277 if (!needsLayout())
279 return; 278 return;
280 279
281 LayoutState rootLayoutState(pageLogicalHeight(), pageLogicalHeightChanged(), 280 LayoutState rootLayoutState(pageLogicalHeight(), *this);
282 *this);
283
284 m_pageLogicalHeightChanged = false;
285 281
286 layoutContent(); 282 layoutContent();
287 283
288 if (layoutOverflowRect() != oldLayoutOverflowRect) { 284 if (layoutOverflowRect() != oldLayoutOverflowRect) {
289 // The document element paints the viewport background, so we need to 285 // The document element paints the viewport background, so we need to
290 // invalidate it when layout overflow changes. 286 // invalidate it when layout overflow changes.
291 // FIXME: Improve viewport background styling/invalidation/painting. 287 // FIXME: Improve viewport background styling/invalidation/painting.
292 // crbug.com/475115 288 // crbug.com/475115
293 if (Element* documentElement = document().documentElement()) { 289 if (Element* documentElement = document().documentElement()) {
294 if (LayoutObject* rootObject = documentElement->layoutObject()) 290 if (LayoutObject* rootObject = documentElement->layoutObject())
(...skipping 762 matching lines...) Expand 10 before | Expand all | Expand 10 after
1057 if (block) 1053 if (block)
1058 block->adjustChildDebugRect(rect); 1054 block->adjustChildDebugRect(rect);
1059 1055
1060 rect.setWidth(LayoutUnit(viewWidth(IncludeScrollbars))); 1056 rect.setWidth(LayoutUnit(viewWidth(IncludeScrollbars)));
1061 rect.setHeight(LayoutUnit(viewHeight(IncludeScrollbars))); 1057 rect.setHeight(LayoutUnit(viewHeight(IncludeScrollbars)));
1062 1058
1063 return rect; 1059 return rect;
1064 } 1060 }
1065 1061
1066 } // namespace blink 1062 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutView.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698