Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutView.h

Issue 2467353003: Remove pageLogicalHeightChanged() from LayoutState. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2006 Apple Computer, Inc. 3 * Copyright (C) 2006 Apple Computer, Inc.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 161
162 LayoutState* layoutState() const { return m_layoutState; } 162 LayoutState* layoutState() const { return m_layoutState; }
163 163
164 void updateHitTestResult(HitTestResult&, const LayoutPoint&) override; 164 void updateHitTestResult(HitTestResult&, const LayoutPoint&) override;
165 165
166 ViewFragmentationContext* fragmentationContext() const { 166 ViewFragmentationContext* fragmentationContext() const {
167 return m_fragmentationContext.get(); 167 return m_fragmentationContext.get();
168 } 168 }
169 169
170 LayoutUnit pageLogicalHeight() const { return m_pageLogicalHeight; } 170 LayoutUnit pageLogicalHeight() const { return m_pageLogicalHeight; }
171 void setPageLogicalHeight(LayoutUnit height) { 171 void setPageLogicalHeight(LayoutUnit height) { m_pageLogicalHeight = height; }
172 if (m_pageLogicalHeight != height) {
173 m_pageLogicalHeight = height;
174 m_pageLogicalHeightChanged = true;
175 }
176 }
177 bool pageLogicalHeightChanged() const { return m_pageLogicalHeightChanged; }
178 172
179 // Notification that this view moved into or out of a native window. 173 // Notification that this view moved into or out of a native window.
180 void setIsInWindow(bool); 174 void setIsInWindow(bool);
181 175
182 PaintLayerCompositor* compositor(); 176 PaintLayerCompositor* compositor();
183 bool usesCompositing() const; 177 bool usesCompositing() const;
184 178
185 LayoutRect backgroundRect(LayoutBox* backgroundLayoutObject) const; 179 LayoutRect backgroundRect(LayoutBox* backgroundLayoutObject) const;
186 180
187 IntRect documentRect() const; 181 IntRect documentRect() const;
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 // TODO(yosin): Clarify the meaning of these variables. editing/ passes 295 // TODO(yosin): Clarify the meaning of these variables. editing/ passes
302 // them as offsets in the DOM tree but layout uses them as offset in the 296 // them as offsets in the DOM tree but layout uses them as offset in the
303 // layout tree. 297 // layout tree.
304 int m_selectionStartPos; 298 int m_selectionStartPos;
305 int m_selectionEndPos; 299 int m_selectionEndPos;
306 300
307 // The page logical height. 301 // The page logical height.
308 // This is only used during printing to split the content into pages. 302 // This is only used during printing to split the content into pages.
309 // Outside of printing, this is 0. 303 // Outside of printing, this is 0.
310 LayoutUnit m_pageLogicalHeight; 304 LayoutUnit m_pageLogicalHeight;
311 bool m_pageLogicalHeightChanged;
312 305
313 // LayoutState is an optimization used during layout. 306 // LayoutState is an optimization used during layout.
314 // |m_layoutState| will be nullptr outside of layout. 307 // |m_layoutState| will be nullptr outside of layout.
315 // 308 //
316 // See the class comment for more details. 309 // See the class comment for more details.
317 LayoutState* m_layoutState; 310 LayoutState* m_layoutState;
318 311
319 std::unique_ptr<ViewFragmentationContext> m_fragmentationContext; 312 std::unique_ptr<ViewFragmentationContext> m_fragmentationContext;
320 std::unique_ptr<PaintLayerCompositor> m_compositor; 313 std::unique_ptr<PaintLayerCompositor> m_compositor;
321 RefPtr<IntervalArena> m_intervalArena; 314 RefPtr<IntervalArena> m_intervalArena;
322 315
323 LayoutQuote* m_layoutQuoteHead; 316 LayoutQuote* m_layoutQuoteHead;
324 unsigned m_layoutCounterCount; 317 unsigned m_layoutCounterCount;
325 318
326 unsigned m_hitTestCount; 319 unsigned m_hitTestCount;
327 unsigned m_hitTestCacheHits; 320 unsigned m_hitTestCacheHits;
328 Persistent<HitTestCache> m_hitTestCache; 321 Persistent<HitTestCache> m_hitTestCache;
329 322
330 Vector<LayoutMedia*> m_mediaForPositionNotification; 323 Vector<LayoutMedia*> m_mediaForPositionNotification;
331 }; 324 };
332 325
333 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutView, isLayoutView()); 326 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutView, isLayoutView());
334 327
335 } // namespace blink 328 } // namespace blink
336 329
337 #endif // LayoutView_h 330 #endif // LayoutView_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutState.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698