Make some android code gender neutral.

Make some android code gender neutral.

Removes gendered pronouns
when refering to users.

BUG=542537
Committed: https://crrev.com/93d83ac96c3d1c27be9ea7e842b25b3dded2550b
Cr-Commit-Position: refs/heads/master@{#430436}

[kcarattini, 2016-11-03 07:50:11]

kcarattini@chromium.org changed reviewers:
+ benwells@chromium.org

[kcarattini, 2016-11-03 08:01:38]

Description was changed from

==========
Make some android code gender neutral.

Follows guidelines at go/gender-neutral-code. Removes gendered pronouns
when refering to users.

BUG=542537
==========

to

==========
Make some android code gender neutral.

Removes gendered pronouns
when refering to users.

BUG=542537
==========

[benwells, 2016-11-03 09:24:13]

lgtm, thanks!

[kcarattini, 2016-11-03 23:32:46]

kcarattini@chromium.org changed reviewers:
+ thestig@chromium.org

[kcarattini, 2016-11-03 23:32:46]

+thestig for owner review

[Lei Zhang, 2016-11-03 23:56:06]

lgtm

[kcarattini, 2016-11-03 23:58:54]

The CQ bit was checked by kcarattini@chromium.org

[commit-bot: I haz the power, 2016-11-03 23:59:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 00:42:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 00:42:03]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Lei Zhang, 2016-11-04 00:48:34]

On 2016/11/04 00:42:03, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

I disagree with the failing presubmit check, but what do I know.

[Lei Zhang, 2016-11-04 00:49:58]

Maybe if you had chrome/android/OWNERS review this instead, they would have
given you better suggestions than my shrug. :)

[kcarattini, 2016-11-04 01:54:28]

kcarattini@chromium.org changed reviewers:
+ miguelg@chromium.org

[kcarattini, 2016-11-04 01:54:28]

+Miguel for advice on the presubmit failure. It doesn't seem like my cl should
have changed anything with the import order, but please let me know if I've
missed something.

[benwells, 2016-11-04 02:16:32]

benwells@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[benwells, 2016-11-04 02:16:33]

+Dan who also might have ideas

[Miguel Garcia, 2016-11-04 10:04:03]

On 2016/11/04 02:16:33, benwells (slow) wrote:
> +Dan who also might have ideas

Note that you are the first person to touch that file since June so I would not
be surprised if the rules have changed since then. Perhaps it's worth to just
reordering the imports to keep the presubmit happy?

[gone, 2016-11-04 16:34:52]

About a month ago, someone landed a change which changed the expected import
order, but didn't actually follow through on fixing all the files.  If you
rearrange your imports, you'll be fine.

[kcarattini, 2016-11-07 00:57:49]

On 2016/11/04 16:34:52, dfalcantara (check my queue) wrote:
> About a month ago, someone landed a change which changed the expected import
> order, but didn't actually follow through on fixing all the files.  If you
> rearrange your imports, you'll be fine.

Thanks. And any advice on what the correct order is? I tried a few guesses that
were wrong, and the error only mentions tools for eclim or eclipse, neither of
which I use (and seems a bit overkill to have to set them up for this).

Kendra

[gone, 2016-11-07 18:45:38]

On 2016/11/07 00:57:49, kcarattini wrote:
> On 2016/11/04 16:34:52, dfalcantara (check my queue) wrote:
> > About a month ago, someone landed a change which changed the expected import
> > order, but didn't actually follow through on fixing all the files.  If you
> > rearrange your imports, you'll be fine.
> 
> Thanks. And any advice on what the correct order is? I tried a few guesses
that
> were wrong, and the error only mentions tools for eclim or eclipse, neither of
> which I use (and seems a bit overkill to have to set them up for this).
> 
> Kendra

Not a clue how the rules changed, and my Eclipse ordering file seems to be out
of date.

Maybe this file will give you some idea?  It's from around when the import
ordering 
rules changed.

https://codereview.chromium.org/2351113005/diff/240001/chrome/android/junit/s...

[kcarattini, 2016-11-07 23:08:34]

On 2016/11/07 18:45:38, dfalcantara (check my queue) wrote:
> On 2016/11/07 00:57:49, kcarattini wrote:
> > On 2016/11/04 16:34:52, dfalcantara (check my queue) wrote:
> > > About a month ago, someone landed a change which changed the expected
import
> > > order, but didn't actually follow through on fixing all the files.  If you
> > > rearrange your imports, you'll be fine.
> > 
> > Thanks. And any advice on what the correct order is? I tried a few guesses
> that
> > were wrong, and the error only mentions tools for eclim or eclipse, neither
of
> > which I use (and seems a bit overkill to have to set them up for this).
> > 
> > Kendra
> 
> Not a clue how the rules changed, and my Eclipse ordering file seems to be out
> of date.
> 
> Maybe this file will give you some idea?  It's from around when the import
> ordering 
> rules changed.
> 
>
https://codereview.chromium.org/2351113005/diff/240001/chrome/android/junit/s...

Thanks. I was able to figure it out from that file.

Kendra

[kcarattini, 2016-11-07 23:10:17]

The CQ bit was checked by kcarattini@chromium.org

[kcarattini, 2016-11-07 23:10:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, benwells@chromium.org
Link to the patchset: https://codereview.chromium.org/2467283004/#ps40001
(title: "Remove extra line")

[commit-bot: I haz the power, 2016-11-07 23:10:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 00:19:46]

Description was changed from

==========
Make some android code gender neutral.

Removes gendered pronouns
when refering to users.

BUG=542537
==========

to

==========
Make some android code gender neutral.

Removes gendered pronouns
when refering to users.

BUG=542537
==========

[commit-bot: I haz the power, 2016-11-08 00:19:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-08 00:33:19]

Description was changed from

==========
Make some android code gender neutral.

Removes gendered pronouns
when refering to users.

BUG=542537
==========

to

==========
Make some android code gender neutral.

Removes gendered pronouns
when refering to users.

BUG=542537

Committed: https://crrev.com/93d83ac96c3d1c27be9ea7e842b25b3dded2550b
Cr-Commit-Position: refs/heads/master@{#430436}
==========

[commit-bot: I haz the power, 2016-11-08 00:33:20]

Patchset 3 (id:??) landed as
https://crrev.com/93d83ac96c3d1c27be9ea7e842b25b3dded2550b
Cr-Commit-Position: refs/heads/master@{#430436}