Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

Issue 2467283004: Make some android code gender neutral. (Closed)
Patch Set: Remove extra line Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.tabmodel; 5 package org.chromium.chrome.browser.tabmodel;
6 6
7 import android.content.Intent; 7 import android.content.Intent;
8 import android.text.TextUtils; 8 import android.text.TextUtils;
9 9
10 import org.chromium.base.SysUtils; 10 import org.chromium.base.SysUtils;
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 * @return the tab the URL was opened in, could be a new tab or a reused one . 223 * @return the tab the URL was opened in, could be a new tab or a reused one .
224 */ 224 */
225 public Tab launchUrlFromExternalApp(String url, String referer, String heade rs, 225 public Tab launchUrlFromExternalApp(String url, String referer, String heade rs,
226 String appId, boolean forceNewTab, Intent intent, long intentTimesta mp) { 226 String appId, boolean forceNewTab, Intent intent, long intentTimesta mp) {
227 assert !mIncognito; 227 assert !mIncognito;
228 boolean isLaunchedFromChrome = TextUtils.equals(appId, mActivity.getPack ageName()); 228 boolean isLaunchedFromChrome = TextUtils.equals(appId, mActivity.getPack ageName());
229 229
230 // If an external app sends an intent for a Weblite URL and the Data Red uction Proxy is 230 // If an external app sends an intent for a Weblite URL and the Data Red uction Proxy is
231 // using Weblite mode, then use the URL in the lite_url parameter if its scheme is HTTP. 231 // using Weblite mode, then use the URL in the lite_url parameter if its scheme is HTTP.
232 // This is used by ChromeTabbedActvity intents so that the user does not receive Weblite 232 // This is used by ChromeTabbedActvity intents so that the user does not receive Weblite
233 // pages when he or she could be served a Data Reduction Proxy preview p age. 233 // pages when they could be served a Data Reduction Proxy preview page.
234 if (url != null) url = DataReductionProxySettings.getInstance().maybeRew riteWebliteUrl(url); 234 if (url != null) url = DataReductionProxySettings.getInstance().maybeRew riteWebliteUrl(url);
235 235
236 if (forceNewTab && !isLaunchedFromChrome) { 236 if (forceNewTab && !isLaunchedFromChrome) {
237 // We don't associate the tab with that app ID, as it is assumed tha t if the 237 // We don't associate the tab with that app ID, as it is assumed tha t if the
238 // application wanted to open this tab as a new tab, it probably doe s not want it 238 // application wanted to open this tab as a new tab, it probably doe s not want it
239 // reused either. 239 // reused either.
240 LoadUrlParams loadUrlParams = new LoadUrlParams(url); 240 LoadUrlParams loadUrlParams = new LoadUrlParams(url);
241 loadUrlParams.setIntentReceivedTimestamp(intentTimestamp); 241 loadUrlParams.setIntentReceivedTimestamp(intentTimestamp);
242 loadUrlParams.setVerbatimHeaders(headers); 242 loadUrlParams.setVerbatimHeaders(headers);
243 if (referer != null) { 243 if (referer != null) {
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 } 328 }
329 329
330 /** 330 /**
331 * @return The default tab delegate factory to be used if creating new tabs w/o parents. 331 * @return The default tab delegate factory to be used if creating new tabs w/o parents.
332 */ 332 */
333 public TabDelegateFactory createDefaultTabDelegateFactory() { 333 public TabDelegateFactory createDefaultTabDelegateFactory() {
334 return new TabDelegateFactory(); 334 return new TabDelegateFactory();
335 } 335 }
336 336
337 } 337 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698