Remove some linked_ptr c/b/extension

Remove some linked_ptr c/b/extension

Use std::unique_ptr instead of deprecated linked_ptr.

BUG=556939
Committed: https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8
Cr-Commit-Position: refs/heads/master@{#430184}

[limasdf, 2016-10-31 14:32:58]

Patchset #1 (id:1) has been deleted

[limasdf, 2016-10-31 14:51:59]

Patchset #1 (id:20001) has been deleted

[limasdf, 2016-10-31 14:52:41]

Patchset #1 (id:40001) has been deleted

[limasdf, 2016-10-31 15:53:50]

Patchset #1 (id:60001) has been deleted

[limasdf, 2016-10-31 18:44:10]

Patchset #1 (id:80001) has been deleted

[limasdf, 2016-10-31 18:57:37]

Description was changed from

==========
Remove some linekd_ptr
BUG=
==========

to

==========
Remove some linekd_ptr c/b/extension

BUG=556939
==========

[limasdf, 2016-10-31 18:57:38]

limasdf@gmail.com changed reviewers:
+ rdevlin.cronin@chromium.org

[limasdf, 2016-10-31 19:00:59]

Hey Devlin, please take a look this clean up when you can find time.

[Devlin, 2016-11-02 22:25:33]

Nice!  Thanks for the cleanup!

https://codereview.chromium.org/2466523002/diff/100001/chrome/browser/extensi...
File chrome/browser/extensions/api/storage/managed_value_store_cache.cc (right):

https://codereview.chromium.org/2466523002/diff/100001/chrome/browser/extensi...
chrome/browser/extensions/api/storage/managed_value_store_cache.cc:360: return
store_map_[extension_id].get();
nit: we can save an extra map lookup here by doing something like:
auto store = base::MakeUnique<PolicyValueStore>(...);
PolicyValueStore* raw_store = store.get();
store_map_[extension_id] = std::move(store);
return raw_store;

https://codereview.chromium.org/2466523002/diff/100001/chrome/browser/extensi...
File chrome/browser/extensions/api/storage/sync_storage_backend.cc (right):

https://codereview.chromium.org/2466523002/diff/100001/chrome/browser/extensi...
chrome/browser/extensions/api/storage/sync_storage_backend.cc:94:
SyncableSettingsStorage* syncable_storage = storage_objs_[extension_id].get();
similar comment here around saving a lookup

https://codereview.chromium.org/2466523002/diff/100001/chrome/browser/extensi...
File chrome/browser/extensions/extension_action_manager.cc (right):

https://codereview.chromium.org/2466523002/diff/100001/chrome/browser/extensi...
chrome/browser/extensions/extension_action_manager.cc:113: return
((*map)[extension.id()]).get();
ditto

https://codereview.chromium.org/2466523002/diff/100001/chrome/browser/extensi...
File chrome/browser/extensions/location_bar_controller.cc (right):

https://codereview.chromium.org/2466523002/diff/100001/chrome/browser/extensi...
chrome/browser/extensions/location_bar_controller.cc:66: action =
active_script_actions_[extension->id()].get();
nit: move this above the insertion, and just do action =
active_script_action.get().

[limasdf, 2016-11-03 13:20:15]

Patchset #2 (id:120001) has been deleted

[limasdf, 2016-11-03 15:29:23]

Thank you for the review. ptal when you can find time.

https://codereview.chromium.org/2466523002/diff/100001/chrome/browser/extensi...
File chrome/browser/extensions/api/storage/managed_value_store_cache.cc (right):

https://codereview.chromium.org/2466523002/diff/100001/chrome/browser/extensi...
chrome/browser/extensions/api/storage/managed_value_store_cache.cc:360: return
store_map_[extension_id].get();
On 2016/11/02 22:25:33, Devlin (slow) wrote:
> nit: we can save an extra map lookup here by doing something like:
> auto store = base::MakeUnique<PolicyValueStore>(...);
> PolicyValueStore* raw_store = store.get();
> store_map_[extension_id] = std::move(store);
> return raw_store;

Done.

https://codereview.chromium.org/2466523002/diff/100001/chrome/browser/extensi...
File chrome/browser/extensions/api/storage/sync_storage_backend.cc (right):

https://codereview.chromium.org/2466523002/diff/100001/chrome/browser/extensi...
chrome/browser/extensions/api/storage/sync_storage_backend.cc:94:
SyncableSettingsStorage* syncable_storage = storage_objs_[extension_id].get();
On 2016/11/02 22:25:33, Devlin (slow) wrote:
> similar comment here around saving a lookup

Done.

https://codereview.chromium.org/2466523002/diff/100001/chrome/browser/extensi...
File chrome/browser/extensions/extension_action_manager.cc (right):

https://codereview.chromium.org/2466523002/diff/100001/chrome/browser/extensi...
chrome/browser/extensions/extension_action_manager.cc:113: return
((*map)[extension.id()]).get();
On 2016/11/02 22:25:33, Devlin (slow) wrote:
> ditto

Done.

https://codereview.chromium.org/2466523002/diff/100001/chrome/browser/extensi...
File chrome/browser/extensions/location_bar_controller.cc (right):

https://codereview.chromium.org/2466523002/diff/100001/chrome/browser/extensi...
chrome/browser/extensions/location_bar_controller.cc:66: action =
active_script_actions_[extension->id()].get();
On 2016/11/02 22:25:33, Devlin (slow) wrote:
> nit: move this above the insertion, and just do action =
> active_script_action.get().

Done.

[Devlin, 2016-11-05 02:08:04]

nice, lgtm!  Thanks for the patch. :)

One last nit, looks like you have a typo in the patch title - linekd -> linked.

[limasdf, 2016-11-05 12:07:18]

Description was changed from

==========
Remove some linekd_ptr c/b/extension

BUG=556939
==========

to

==========
Remove some linked_ptr c/b/extension

Use std::unique_ptr instead of deprecated linked_ptr.

BUG=556939
==========

[limasdf, 2016-11-05 12:07:32]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2016-11-05 12:07:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 12:49:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-05 12:49:15]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[limasdf, 2016-11-06 04:28:21]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2016-11-06 04:28:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-06 04:54:55]

Description was changed from

==========
Remove some linked_ptr c/b/extension

Use std::unique_ptr instead of deprecated linked_ptr.

BUG=556939
==========

to

==========
Remove some linked_ptr c/b/extension

Use std::unique_ptr instead of deprecated linked_ptr.

BUG=556939
==========

[commit-bot: I haz the power, 2016-11-06 04:54:56]

Committed patchset #2 (id:140001)

[commit-bot: I haz the power, 2016-11-06 04:57:23]

Description was changed from

==========
Remove some linked_ptr c/b/extension

Use std::unique_ptr instead of deprecated linked_ptr.

BUG=556939
==========

to

==========
Remove some linked_ptr c/b/extension

Use std::unique_ptr instead of deprecated linked_ptr.

BUG=556939

Committed: https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8
Cr-Commit-Position: refs/heads/master@{#430184}
==========

[commit-bot: I haz the power, 2016-11-06 04:57:24]

Patchset 2 (id:??) landed as
https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8
Cr-Commit-Position: refs/heads/master@{#430184}