Remove some linked_ptr c/b/extension

chrome/browser/extensions/extension_action_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_action_manager.h"
 
 #include "chrome/browser/extensions/api/system_indicator/system_indicator_manager_factory.h"
 #include "chrome/browser/extensions/extension_action.h"
 #include "chrome/browser/profiles/profile.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
@@ skipping 67 matching lines @@
     const Extension* extension,
     UnloadedExtensionInfo::Reason reason) {
   page_actions_.erase(extension->id());
   browser_actions_.erase(extension->id());
   system_indicators_.erase(extension->id());
 }
 
 namespace {
 
 // Returns map[extension_id] if that entry exists. Otherwise, if
-// action_info!=NULL, creates an ExtensionAction from it, fills in the map, and
-// returns that.  Otherwise (action_info==NULL), returns NULL.
+// action_info!=nullptr, creates an ExtensionAction from it, fills in the map,
+// and returns that.  Otherwise (action_info==nullptr), returns nullptr.
 ExtensionAction* GetOrCreateOrNull(
-    std::map<std::string, linked_ptr<ExtensionAction> >* map,
+    std::map<std::string, std::unique_ptr<ExtensionAction>>* map,
     const Extension& extension,
     ActionInfo::Type action_type,
     const ActionInfo* action_info,
     Profile* profile) {
-  std::map<std::string, linked_ptr<ExtensionAction> >::const_iterator it =
-      map->find(extension.id());
+  auto it = map->find(extension.id());
   if (it != map->end())
     return it->second.get();
   if (!action_info)
-    return NULL;
+    return nullptr;
 
   // Only create action info for enabled extensions.
   // This avoids bugs where actions are recreated just after being removed
   // in response to OnExtensionUnloaded().
   if (!ExtensionRegistry::Get(profile)
       ->enabled_extensions().Contains(extension.id())) {
-    return NULL;
+    return nullptr;
   }
 
-  linked_ptr<ExtensionAction> action(new ExtensionAction(
-      extension, action_type, *action_info));
-  (*map)[extension.id()] = action;
-  return action.get();
+  std::unique_ptr<ExtensionAction> action(
+      new ExtensionAction(extension, action_type, *action_info));
+  (*map)[extension.id()] = std::move(action);
+  return ((*map)[extension.id()]).get();

[Devlin, 2016/11/02 22:25:33]

ditto

[limasdf, 2016/11/03 15:29:23]

Done.

 }
 
 }  // namespace
 
 ExtensionAction* ExtensionActionManager::GetPageAction(
     const Extension& extension) const {
   return GetOrCreateOrNull(&page_actions_, extension,
                            ActionInfo::TYPE_PAGE,
                            ActionInfo::GetPageActionInfo(&extension),
                            profile_);
@@ skipping 11 matching lines @@
     const Extension& extension,
     ActionInfo::Type type) const {
   const ActionInfo* info = ActionInfo::GetBrowserActionInfo(&extension);
   if (!info)
     info = ActionInfo::GetPageActionInfo(&extension);
 
   // Create a new ExtensionAction of |type| with |extension|'s ActionInfo.
   // If no ActionInfo exists for |extension|, create and return a new action
   // with a blank ActionInfo.
   // Populate any missing values from |extension|'s manifest.
-  std::unique_ptr<ExtensionAction> new_action(
-      new ExtensionAction(extension, type, info ? *info : ActionInfo()));
-  return new_action;
+  return base::MakeUnique<ExtensionAction>(extension, type,
+                                           info ? *info : ActionInfo());
 }
 
 ExtensionAction* ExtensionActionManager::GetSystemIndicator(
     const Extension& extension) const {
   // If it does not already exist, create the SystemIndicatorManager for the
   // given profile.  This could return NULL if the system indicator area is
   // unavailable on the current system.  If so, return NULL to signal that
   // the system indicator area is unusable.
   if (!SystemIndicatorManagerFactory::GetForProfile(profile_))
-    return NULL;
+    return nullptr;
 
   return GetOrCreateOrNull(&system_indicators_, extension,
                            ActionInfo::TYPE_SYSTEM_INDICATOR,
                            ActionInfo::GetSystemIndicatorInfo(&extension),
                            profile_);
 }
 
 ExtensionAction* ExtensionActionManager::GetExtensionAction(
     const Extension& extension) const {
   ExtensionAction* action = GetBrowserAction(extension);
   return action ? action : GetPageAction(extension);
 }
 
 }  // namespace extensions