Remove some linked_ptr c/b/extension

chrome/browser/extensions/location_bar_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/location_bar_controller.h"
 
 #include <algorithm>
 
 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
 #include "chrome/browser/extensions/extension_action_manager.h"
@@ skipping 38 matching lines @@
     // Right now, we can consolidate these actions because we only want to show
     // one action per extension. If clicking on an active script action ever
     // has a response, then we will need to split the actions.
     ExtensionAction* action = action_manager_->GetPageAction(*extension);
     if (!action && action_executor->WantsToRun(extension.get())) {
       ExtensionActionMap::iterator existing =
           active_script_actions_.find(extension->id());
       if (existing != active_script_actions_.end()) {
         action = existing->second.get();
       } else {
-        linked_ptr<ExtensionAction> active_script_action(
-            ExtensionActionManager::Get(browser_context_)->
-                GetBestFitAction(*extension, ActionInfo::TYPE_PAGE).release());
+        std::unique_ptr<ExtensionAction> active_script_action =
+            ExtensionActionManager::Get(browser_context_)
+                ->GetBestFitAction(*extension, ActionInfo::TYPE_PAGE);
         active_script_action->SetIsVisible(
             ExtensionAction::kDefaultTabId, true);
-        active_script_actions_[extension->id()] = active_script_action;
-        action = active_script_action.get();
+        active_script_actions_[extension->id()] =
+            std::move(active_script_action);
+        action = active_script_actions_[extension->id()].get();

[Devlin, 2016/11/02 22:25:33]

nit: move this above the insertion, and just do action =
active_script_action.get().

[limasdf, 2016/11/03 15:29:23]

Done.

       }
     }
 
     if (action)
       current_actions.push_back(action);
   }
 
   // Sort by id to guarantee the extension actions are returned in the same
   // order every time this function is called.
   std::sort(current_actions.begin(), current_actions.end(),
@@ skipping 45 matching lines @@
     content::BrowserContext* browser_context,
     const Extension* extension,
     UnloadedExtensionInfo::Reason reason) {
   if (should_show_page_actions_ && action_manager_->GetPageAction(*extension)) {
     ExtensionActionAPI::Get(browser_context)->
         NotifyPageActionsChanged(web_contents_);
   }
 }
 
 }  // namespace extensions