Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2466353002: Revert "More functionality in kernel_impact." and "Compute NativeBehavior for foreign functions." (Closed)

Created:
4 years, 1 month ago by Johnni Winther
Modified:
4 years, 1 month ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "More functionality in kernel_impact." and "Compute NativeBehavior for foreign functions." This reverts commit a0bccd5c88a94d91aec03cd1eb3a7c26ab2c6091. This reverts commit 7db10e4d435dd8026b03adfa912814491977f1af. Committed: https://github.com/dart-lang/sdk/commit/8e48be6915371a131687d534c28521bea1385ab5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -870 lines) Patch
M pkg/compiler/lib/src/common/names.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 2 chunks +0 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_debug.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 16 chunks +137 lines, -239 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 5 chunks +12 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 2 chunks +2 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/serialization/system.dart View 2 chunks +5 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 6 chunks +2 lines, -166 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 6 chunks +31 lines, -142 lines 0 comments Download
M tests/compiler/dart2js/js_spec_string_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 14 chunks +38 lines, -222 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
TBR
4 years, 1 month ago (2016-11-01 14:02:30 UTC) #2
Johnni Winther
Committed patchset #1 (id:1) manually as 8e48be6915371a131687d534c28521bea1385ab5 (presubmit successful).
4 years, 1 month ago (2016-11-01 14:05:02 UTC) #4
Harry Terkelsen
4 years, 1 month ago (2016-11-01 15:58:10 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698