Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 2466353002: Revert "More functionality in kernel_impact." and "Compute NativeBehavior for foreign functions." (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index 83e44e7c95b9decdb804ef65f8484f0dbd9ff11e..5b843feaa59729d69ab8c22eeb764851ecdd85ae 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -854,7 +854,7 @@ class JavaScriptBackend extends Backend {
.handleMethodAnnotations(element);
if (isNative(element)) {
native.NativeBehavior behavior =
- native.NativeBehavior.ofMethodElement(element, compiler);
+ native.NativeBehavior.ofMethod(element, compiler);
nativeData.setNativeMethodBehavior(element, behavior);
registry.registerNativeData(behavior);
}
@@ -863,9 +863,9 @@ class JavaScriptBackend extends Backend {
.handleFieldAnnotations(element);
if (isNative(element)) {
native.NativeBehavior fieldLoadBehavior =
- native.NativeBehavior.ofFieldElementLoad(element, compiler);
- native.NativeBehavior fieldStoreBehavior = native.NativeBehavior
- .ofFieldElementStore(element, compiler.resolution);
+ native.NativeBehavior.ofFieldLoad(element, compiler);
+ native.NativeBehavior fieldStoreBehavior =
+ native.NativeBehavior.ofFieldStore(element, compiler);
nativeData.setNativeFieldLoadBehavior(element, fieldLoadBehavior);
nativeData.setNativeFieldStoreBehavior(element, fieldStoreBehavior);
@@ -1434,13 +1434,13 @@ class JavaScriptBackend extends Backend {
CallStructure callStructure, ForeignResolver resolver) {
native.NativeResolutionEnqueuer nativeEnqueuer =
compiler.enqueuer.resolution.nativeEnqueuer;
- if (element.name == BackendHelpers.JS) {
+ if (element.name == 'JS') {
return nativeEnqueuer.resolveJsCall(node, resolver);
- } else if (element.name == BackendHelpers.JS_EMBEDDED_GLOBAL) {
+ } else if (element.name == 'JS_EMBEDDED_GLOBAL') {
return nativeEnqueuer.resolveJsEmbeddedGlobalCall(node, resolver);
- } else if (element.name == BackendHelpers.JS_BUILTIN) {
+ } else if (element.name == 'JS_BUILTIN') {
return nativeEnqueuer.resolveJsBuiltinCall(node, resolver);
- } else if (element.name == BackendHelpers.JS_INTERCEPTOR_CONSTANT) {
+ } else if (element.name == 'JS_INTERCEPTOR_CONSTANT') {
// The type constant that is an argument to JS_INTERCEPTOR_CONSTANT names
// a class that will be instantiated outside the program by attaching a
// native class dispatch record referencing the interceptor.
« no previous file with comments | « pkg/compiler/lib/src/diagnostics/messages.dart ('k') | pkg/compiler/lib/src/js_backend/backend_helpers.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698