Revert "More functionality in kernel_impact." and "Compute NativeBehavior for foreign functions."

pkg/compiler/lib/src/resolution/members.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.resolution.members;
 
 import '../common.dart';
 import '../common/names.dart' show Selectors;
 import '../common/resolution.dart' show Resolution;
 import '../compile_time_constants.dart';
@@ skipping 438 matching lines @@
         addToScope(parameterElement);
       }
       parameterNodes = parameterNodes.tail;
     });
     addDeferredAction(enclosingElement, () {
       functionSignature.forEachOptionalParameter((ParameterElementX parameter) {
         parameter.constant =
             resolver.constantCompiler.compileConstant(parameter);
       });
     });
-    registry.registerCheckedModeCheck(functionSignature.returnType);
+    if (!functionSignature.returnType.isDynamic) {
+      registry.registerTypeUse(
+          new TypeUse.checkedModeCheck(functionSignature.returnType));
+    }
     functionSignature.forEachParameter((ParameterElement element) {
-      registry.registerCheckedModeCheck(element.type);
+      if (!element.type.isDynamic) {
+        registry.registerTypeUse(new TypeUse.checkedModeCheck(element.type));
+      }
     });
   }
 
   ResolutionResult visitAssert(Assert node) {
     if (!options.enableAssertMessage) {
       if (node.hasMessage) {
         reporter.reportErrorMessage(
             node, MessageKind.EXPERIMENTAL_ASSERT_MESSAGE);
       }
     }
@@ skipping 1871 matching lines @@
       } else {
         // TODO(johnniwinther): Handle invalid this access as an
         // [AccessSemantics].
         return handleErroneousAccess(node, name, semantics);
       }
     }
     ResolutionResult result = visitExpressionPrefix(node.receiver);
     if (result.kind == ResultKind.PREFIX) {
       return handlePrefixSend(node, name, result);
     } else if (node.isConditional) {
-      registry.registerConstantLiteral(new NullConstantExpression());
-      registry.registerDynamicUse(new DynamicUse(Selectors.equals, null));
       return handleDynamicAccessSemantics(
           node, name, new DynamicAccess.ifNotNullProperty(name));
     } else {
       // Handle dynamic property access, like `a.b` or `a.b()` where `a` is not
       // a prefix or class.
       // TODO(johnniwinther): Use the `element` of [result].
       return handleDynamicAccessSemantics(
           node, name, new DynamicAccess.dynamicProperty(name));
     }
   }
@@ skipping 13 matching lines @@
       } else {
         // TODO(johnniwinther): Handle invalid this access as an
         // [AccessSemantics].
         return handleUpdate(node, name, semantics);
       }
     }
     ResolutionResult result = visitExpressionPrefix(node.receiver);
     if (result.kind == ResultKind.PREFIX) {
       return handlePrefixSendSet(node, name, result);
     } else if (node.isConditional) {
-      registry.registerConstantLiteral(new NullConstantExpression());
-      registry.registerDynamicUse(new DynamicUse(Selectors.equals, null));
       return handleDynamicUpdateSemantics(
           node, name, null, new DynamicAccess.ifNotNullProperty(name));
     } else {
       // Handle dynamic property access, like `a.b = c`, `a.b++` or `a.b += c`
       // where `a` is not a prefix or class.
       // TODO(johnniwinther): Use the `element` of [result].
       return handleDynamicUpdateSemantics(
           node, name, null, new DynamicAccess.dynamicProperty(name));
     }
   }
@@ skipping 1672 matching lines @@
         inConstContext: inConstContext));
   }
 
   DartType resolveTypeAnnotation(TypeAnnotation node,
       {bool malformedIsError: false,
       bool deferredIsMalformed: true,
       bool registerCheckedModeCheck: true}) {
     DartType type = typeResolver.resolveTypeAnnotation(this, node,
         malformedIsError: malformedIsError,
         deferredIsMalformed: deferredIsMalformed);
-    if (registerCheckedModeCheck) {
-      registry.registerCheckedModeCheck(type);
+    if (registerCheckedModeCheck && !type.isDynamic) {
+      registry.registerTypeUse(new TypeUse.checkedModeCheck(type));
     }
     return type;
   }
 
   ResolutionResult visitLiteralList(LiteralList node) {
     bool isValidAsConstant = true;
     sendIsMemberAccess = false;
 
     NodeList arguments = node.typeArguments;
     DartType typeArgument;
@@ skipping 505 matching lines @@
         continueLabels[labelName] = labelElement;
       }
       cases = cases.tail;
       // Test that only the last case, if any, is a default case.
       if (switchCase.defaultKeyword != null && !cases.isEmpty) {
         reporter.reportErrorMessage(
             switchCase, MessageKind.INVALID_CASE_DEFAULT);
       }
       if (cases.isNotEmpty && switchCase.statements.isNotEmpty) {
         Node last = switchCase.statements.last;
-        if (last.asReturn() == null &&
-            last.asBreakStatement() == null &&
+        if (last.asBreakStatement() == null &&
             last.asContinueStatement() == null &&
-            (last.asExpressionStatement() == null ||
-                last.asExpressionStatement().expression.asThrow() == null)) {
+            last.asThrow() == null &&
+            last.asReturn() == null) {
           registry.registerFeature(Feature.FALL_THROUGH_ERROR);
         }
       }
     }
 
     addDeferredAction(enclosingElement, () {
       checkCaseExpressions(node);
     });
 
     statementScope.enterSwitch(breakElement, continueLabels);
@@ skipping 119 matching lines @@
     }
     return const NoneResult();
   }
 }
 
 /// Looks up [name] in [scope] and unwraps the result.
 Element lookupInScope(
     DiagnosticReporter reporter, Node node, Scope scope, String name) {
   return Elements.unwrap(scope.lookup(name), reporter, node);
 }