Don't paint repeating header if only the border spacing exceeds page height

Don't paint repeating header if only the border spacing exceeds page height

BUG=642814
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/be9e1f1ffc1e1d3287c7d994587446f9d7e703ee
Cr-Commit-Position: refs/heads/master@{#429464}

[rhogan, 2016-11-01 20:25:19]

Description was changed from

==========
Don't paint repeating header if only the border spacing exceeds page height

BUG=642814
==========

to

==========
Don't paint repeating header if only the border spacing exceeds page height

BUG=642814
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[rhogan, 2016-11-01 20:25:55]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 20:26:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rhogan, 2016-11-01 20:37:37]

robhogan@gmail.com changed reviewers:
+ wangxianzhu@chromium.org

[mstensho (USE GERRIT), 2016-11-01 20:41:32]

mstensho@opera.com changed reviewers:
+ mstensho@opera.com

[mstensho (USE GERRIT), 2016-11-01 20:41:32]

https://codereview.chromium.org/2466253004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/TableSectionPainter.cpp (right):

https://codereview.chromium.org/2466253004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/TableSectionPainter.cpp:74: paintOffset.y()
+ (table->logicalHeight() - table->vBorderSpacing()));
What if it's only bottom captions that exceed the height?

[commit-bot: I haz the power, 2016-11-01 21:48:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 21:48:54]

Dry run: This issue passed the CQ dry run.

[rhogan, 2016-11-02 19:42:50]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[rhogan, 2016-11-02 19:42:55]

On 2016/11/01 at 20:41:32, mstensho wrote:
>
https://codereview.chromium.org/2466253004/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/paint/TableSectionPainter.cpp (right):
> 
>
https://codereview.chromium.org/2466253004/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/paint/TableSectionPainter.cpp:74:
paintOffset.y() + (table->logicalHeight() - table->vBorderSpacing()));
> What if it's only bottom captions that exceed the height?

Argh, I should have thought of that. Hopefully the updated CL is an improvement.

[commit-bot: I haz the power, 2016-11-02 19:43:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mstensho (USE GERRIT), 2016-11-02 20:14:26]

lgtm

https://codereview.chromium.org/2466253004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/TableSectionPainter.cpp (right):

https://codereview.chromium.org/2466253004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/TableSectionPainter.cpp:78:
sectionsRect.height() - table->vBorderSpacing();
This is wrong in vertical writing modes, but I guess it's always been so...

[rhogan, 2016-11-02 21:40:36]

The CQ bit was unchecked by robhogan@gmail.com

[rhogan, 2016-11-02 21:40:38]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2016-11-02 21:41:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 00:04:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-03 00:07:59]

Description was changed from

==========
Don't paint repeating header if only the border spacing exceeds page height

BUG=642814
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't paint repeating header if only the border spacing exceeds page height

BUG=642814
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/be9e1f1ffc1e1d3287c7d994587446f9d7e703ee
Cr-Commit-Position: refs/heads/master@{#429464}
==========

[commit-bot: I haz the power, 2016-11-03 00:08:00]

Patchset 2 (id:??) landed as
https://crrev.com/be9e1f1ffc1e1d3287c7d994587446f9d7e703ee
Cr-Commit-Position: refs/heads/master@{#429464}