Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2479333002:
Ensure line-break is on correct object if trailing collapsed whitespace pushes us over line-end (Closed)
|
Created:
4 years, 1 month ago by rhogan Modified:
3 years, 9 months ago Reviewers:
eae CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnsure line-break is on correct object if trailing collapsed whitespace pushes us over line-end
If we're going to break on an auto-wrap line due to trailing space make sure
the line break has been moved to the next available next layout object on the line.
BUG=641334
Review-Url: https://codereview.chromium.org/2479333002
Cr-Commit-Position: refs/heads/master@{#459052}
Committed: https://chromium.googlesource.com/chromium/src/+/068a38e0f20762a3f218a88aba3290ad83d6e255
Patch Set 1 #Patch Set 2 : bug 641334 #Patch Set 3 : bug 641334 #Patch Set 4 : bug 641334 #Patch Set 5 : bug 641334 #Patch Set 6 : Don't append float to the current last line if there are clean lines with floats #Patch Set 7 : Ensure line-break is on correct object if trailing collapsed whitespace pushes us over line-end #
Messages
Total messages: 41 (35 generated)
The CQ bit was checked by robhogan@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by robhogan@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by robhogan@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by robhogan@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by robhogan@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by robhogan@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by robhogan@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Description was changed from ========== Don't append float to the current last line if there are clean lines with floats BUG=641334 ========== to ========== Ensure line-break is on correct object if trailing collapsed whitespace pushes us over line-end If we're going to break on an auto-wrap line due to trailing space make sure the line break has been moved to the next available next layout object on the line. BUG=641334 ==========
Description was changed from ========== Don't append float to the current last line if there are clean lines with floats BUG=641334 ========== to ========== Ensure line-break is on correct object if trailing collapsed whitespace pushes us over line-end If we're going to break on an auto-wrap line due to trailing space make sure the line break has been moved to the next available next layout object on the line. BUG=641334 ==========
robhogan@gmail.com changed reviewers: + eae@chromium.org
On 2017/03/20 at 18:41:02, rhogan wrote: > The test still fails in layout_ng so I will skip it there for now.
On 2017/03/20 at 18:41:02, rhogan wrote: > The test still fails in layout_ng so I will skip it there for now.
Thank you. LGTM
The CQ bit was checked by robhogan@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org Link to the patchset: https://codereview.chromium.org/2479333002/#ps120001 (title: "Ensure line-break is on correct object if trailing collapsed whitespace pushes us over line-end")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1490266824804570,
"parent_rev": "702773295d84656c8ad92eb7e700419214fbaf86", "commit_rev":
"068a38e0f20762a3f218a88aba3290ad83d6e255"}
Message was sent while issue was closed.
Description was changed from ========== Ensure line-break is on correct object if trailing collapsed whitespace pushes us over line-end If we're going to break on an auto-wrap line due to trailing space make sure the line break has been moved to the next available next layout object on the line. BUG=641334 ========== to ========== Ensure line-break is on correct object if trailing collapsed whitespace pushes us over line-end If we're going to break on an auto-wrap line due to trailing space make sure the line break has been moved to the next available next layout object on the line. BUG=641334 Review-Url: https://codereview.chromium.org/2479333002 Cr-Commit-Position: refs/heads/master@{#459052} Committed: https://chromium.googlesource.com/chromium/src/+/068a38e0f20762a3f218a88aba32... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/068a38e0f20762a3f218a88aba32... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
