Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTable.cpp

Issue 2466253004: Don't paint repeating header if only the border spacing exceeds page height (Closed)
Patch Set: bug 642814 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 9 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
10 * 10 *
(...skipping 716 matching lines...) Expand 10 before | Expand all | Expand 10 after
727 727
728 updateLayerTransformAfterLayout(); 728 updateLayerTransformAfterLayout();
729 729
730 // Layout was changed, so probably borders too. 730 // Layout was changed, so probably borders too.
731 invalidateCollapsedBorders(); 731 invalidateCollapsedBorders();
732 732
733 computeOverflow(clientLogicalBottom()); 733 computeOverflow(clientLogicalBottom());
734 updateAfterLayout(); 734 updateAfterLayout();
735 735
736 if (state.pageLogicalHeight()) { 736 if (state.pageLogicalHeight()) {
737 m_blockOffsetToFirstRepeatableHeader = 737 m_blockOffsetToFirstRepeatableHeader = state.pageLogicalOffset(
738 state.pageLogicalOffset(*this, LayoutUnit()); 738 *this, topSection ? topSection->logicalTop() : LayoutUnit());
739 } 739 }
740 } 740 }
741 741
742 // FIXME: This value isn't the intrinsic content logical height, but we need 742 // FIXME: This value isn't the intrinsic content logical height, but we need
743 // to update the value as its used by flexbox layout. crbug.com/367324 743 // to update the value as its used by flexbox layout. crbug.com/367324
744 setIntrinsicContentLogicalHeight(contentLogicalHeight()); 744 setIntrinsicContentLogicalHeight(contentLogicalHeight());
745 745
746 m_columnLogicalWidthChanged = false; 746 m_columnLogicalWidthChanged = false;
747 clearNeedsLayout(); 747 clearNeedsLayout();
748 } 748 }
(...skipping 943 matching lines...) Expand 10 before | Expand all | Expand 10 after
1692 } 1692 }
1693 1693
1694 LayoutUnit LayoutTable::paddingRight() const { 1694 LayoutUnit LayoutTable::paddingRight() const {
1695 if (collapseBorders()) 1695 if (collapseBorders())
1696 return LayoutUnit(); 1696 return LayoutUnit();
1697 1697
1698 return LayoutBlock::paddingRight(); 1698 return LayoutBlock::paddingRight();
1699 } 1699 }
1700 1700
1701 } // namespace blink 1701 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698