Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-found.html

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)
Patch Set: Ensure that we throw a kGattServerNotConnected error if getDescriptor[s] is called while not connec… Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-found.html
diff --git a/third_party/WebKit/LayoutTests/bluetooth/notifications/stop-without-starting.html b/third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-found.html
similarity index 57%
copy from third_party/WebKit/LayoutTests/bluetooth/notifications/stop-without-starting.html
copy to third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-found.html
index 7cbb02923277a8249db0a1bc80b9830129cd2025..de47e185f05b7319c3ad11798b7f40d03e9f0731 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/notifications/stop-without-starting.html
+++ b/third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-found.html
@@ -4,13 +4,20 @@
<script src="../../resources/bluetooth/bluetooth-helpers.js"></script>
<script>
'use strict';
+
ortuno 2016/11/21 03:34:09 Use the test generator e.g. // script-tests/descr
promise_test(() => {
return setBluetoothFakeAdapter('HeartRateAdapter')
.then(() => requestDeviceWithKeyDown({
- filters: [{services: ['heart_rate']}]}))
+ filters: [{services: ['heart_rate']}],
+ optionalServices: ['generic_access']}))
.then(device => device.gatt.connect())
.then(gattServer => gattServer.getPrimaryService('heart_rate'))
.then(service => service.getCharacteristic('heart_rate_measurement'))
- .then(characteristic => characteristic.stopNotifications());
-}, "Stop without starting.");
+ .then(characteristic => characteristic.getDescriptor(user_description.alias))
+ .then(descriptor => {
+ assert_equals(
+ descriptor.uuid, user_description.uuid,
+ 'Descriptor UUID should be as requested.');
+ })
+}, 'Request for descriptor. Should return right descriptor');
</script>

Powered by Google App Engine
This is Rietveld 408576698