third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-blacklisted.html - Issue 2466223002: Implement WebBluetooth getDescriptor[s]

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-blacklisted.html

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)

Patch Set: Ensure that we throw a kGattServerNotConnected error if getDescriptor[s] is called while not connec… Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/bluetooth/test/mock_bluetooth_gatt_characteristic.h ('K') | « device/bluetooth/test/mock_bluetooth_gatt_characteristic.cc ('k') | third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-found.html » ('j') | third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-found.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-blacklisted.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-blacklisted.html b/third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-blacklisted.html

new file mode 100644

index 0000000000000000000000000000000000000000..d571545666e3804b5ac393166c3679f1af1443e8

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-blacklisted.html

@@ -0,0 +1,28 @@

+<!DOCTYPE html>

ortuno 2016/11/21 03:34:09 Can you change the name to descriptor-write-blackl

dougt 2016/11/22 01:47:16 Acknowledged.

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+<script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

+<script>

+'use strict';

+promise_test(() => {

+ return setBluetoothFakeAdapter('HeartRateAdapter')

+ .then(() => requestDeviceWithKeyDown({

+ filters: [{services: ['heart_rate']}],

+ optionalServices: ['generic_access']}))

+ .then(device => device.gatt.connect())

+ .then(gattServer => gattServer.getPrimaryService('heart_rate'))

+ .then(service => service.getCharacteristic('heart_rate_measurement'))

+// This UUID is for the client config which is black listed on write.

+ .then(characteristic => characteristic.getDescriptor("00002902-0000-1000-8000-00805f9b34fb"))

ortuno 2016/11/21 03:34:08 No need for the whole UUID since it's a standard U

dougt 2016/11/22 01:47:16 Acknowledged.

+ .then(descriptor => {

+ assert_promise_rejects_with_message(

ortuno 2016/11/21 03:34:08 Either return or don't use '{' so that it's implic

dougt 2016/11/22 01:47:16 Acknowledged.

+ descriptor.writeValue(new Uint8Array(1)),

ortuno 2016/11/21 03:34:08 Also add a test for excluded-read. There is an exc

+ new DOMException(

+ 'writeValue() called on blacklisted object marked exclude-writes.' +

+ ' https://goo.gl/4NeimX',

+ 'SecurityError'),

+ 'writeValue() should reject.')

+ })

+}, 'Blacklisted writes must fail.');

+</script>