third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-found.html - Issue 2466223002: Implement WebBluetooth getDescriptor[s]

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-found.html

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)

Patch Set: Ensure that we throw a kGattServerNotConnected error if getDescriptor[s] is called while not connec… Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-blacklisted.html ('K') | « third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-blacklisted.html ('k') | third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-not_found.html » ('j') | third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/testharness.js"></script>	2 <script src="../../resources/testharness.js"></script>

3 <script src="../../resources/testharnessreport.js"></script>	3 <script src="../../resources/testharnessreport.js"></script>

4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

5 <script>	5 <script>

6 'use strict';	6 'use strict';

	7
	ortuno 2016/11/21 03:34:09 Use the test generator e.g. // script-tests/descr Use the test generator e.g. // script-tests/descriptor-found.js 'use strict'; promise_test(() => { return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter') .then(() => requestDeviceWithKeyDown({filters: ['health_thermometer']}) .then(device => device.gatt.connect()) .then(gattServer => gattServer.getPrimaryService('health_thermometer')) .then(service => service.getCharacteristic('measurement_interval')) .then(characteristic => characteristic.CALLS([ getDescriptor('valid_range')\| getDescriptors('valid_range')[UUID]])) .then(descriptors => { // Convert to array if necessary. descriptors = [].concat(descriptors); descriptors.forEach(descriptor => { assert_equals(descriptor.uuid, BluetoothUUID.getDescriptor('valid_range')); }); }); }, 'Request for descriptor. Should return right descriptor.'); Because of CALLS([getDescriptor(...)\| getDescriptors(...)[UUID]), generator.py will generate two tests: getDescriptor/gen-descriptor-found.html getDescriptors/gen-descriptor-found-with-uuid.html
7 promise_test(() => {	8 promise_test(() => {

8 return setBluetoothFakeAdapter('HeartRateAdapter')	9 return setBluetoothFakeAdapter('HeartRateAdapter')

9 .then(() => requestDeviceWithKeyDown({	10 .then(() => requestDeviceWithKeyDown({

10 filters: [{services: ['heart_rate']}]}))	11 filters: [{services: ['heart_rate']}],

	12 optionalServices: ['generic_access']}))

11 .then(device => device.gatt.connect())	13 .then(device => device.gatt.connect())

12 .then(gattServer => gattServer.getPrimaryService('heart_rate'))	14 .then(gattServer => gattServer.getPrimaryService('heart_rate'))

13 .then(service => service.getCharacteristic('heart_rate_measurement'))	15 .then(service => service.getCharacteristic('heart_rate_measurement'))

14 .then(characteristic => characteristic.stopNotifications());	16 .then(characteristic => characteristic.getDescriptor(user_description.alias) )

15 }, "Stop without starting.");	17 .then(descriptor => {

	18 assert_equals(

	19 descriptor.uuid, user_description.uuid,

	20 'Descriptor UUID should be as requested.');

	21 })

	22 }, 'Request for descriptor. Should return right descriptor');

16 </script>	23 </script>

OLD	NEW