Make download warning icon and text more consistent

Make download warning icon and text more consistent

(1) replace previous dangerous warning icons (circle with dash and
  yellow triangle) to red triangles
(2) make the color of this icon consistent on download shelf and
   download page (rgb color DD4330)
(3) make the warning text color consistent with icon color

BUG=657520, 657523
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c
Cr-Commit-Position: refs/heads/master@{#429324}

[Jialiu Lin, 2016-10-31 23:50:00]

Description was changed from

==========
Make download warning icon and text more consistent

(1) replace previous dangerous warning icons (circle with dash and
  yellow triangle) to red triangles
(2) make the color of this icon consistent on download shelf and
   download page (rgb color DD4330)
(3) make the warning text color consistent with icon color

BUG=657520, 657523
==========

to

==========
Make download warning icon and text more consistent

(1) replace previous dangerous warning icons (circle with dash and
  yellow triangle) to red triangles
(2) make the color of this icon consistent on download shelf and
   download page (rgb color DD4330)
(3) make the warning text color consistent with icon color

BUG=657520, 657523
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Jialiu Lin, 2016-10-31 23:50:43]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 23:51:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 23:54:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 23:54:29]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Jialiu Lin, 2016-11-01 00:13:30]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 00:14:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 01:30:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 01:30:59]

Dry run: This issue passed the CQ dry run.

[Jialiu Lin, 2016-11-01 18:38:34]

jialiul@chromium.org changed reviewers:
+ dbeam@chromium.org

[Jialiu Lin, 2016-11-01 18:38:35]

Hi dbeam@, 
Could you take a look at this CL to see if it makes sense?
(I'm not sure if I should directly edit crisper.js file. It seems generated
somehow.) Thanks!

[Dan Beam, 2016-11-01 18:49:50]

On 2016/11/01 18:38:35, Jialiu Lin wrote:
> Hi dbeam@, 
> Could you take a look at this CL to see if it makes sense?
> (I'm not sure if I should directly edit crisper.js file. It seems generated
> somehow.) Thanks!

you should run chrome/browser/resources/vulcanize.py

here's more info:
https://chromium.googlesource.com/chromium/src/+/master/docs/vulcanize.md

https://codereview.chromium.org/2465723004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_downloads/item.html (right):

https://codereview.chromium.org/2465723004/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_downloads/item.html:116: color: rgb(221, 67, 48);
this similar to --google-red-700 and --paper-deep-orange-800, so maybe we could
just use either of those instead?

if not, you could do something like:

#danger-icon[icon='cr:warning'],
.dangerous #description {
  color: rgb(221, 67, 48);
}

or

:host {
  --dangerous-color: rgb(221, 67, 48);
}

#danger-icon[icon='cr:warning'] {
  color: var(--dangerous-color);
}

/* ... */

.dangerous #description {
  color: var(--dangerous-color);
}

https://codereview.chromium.org/2465723004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_downloads/item.js (right):

https://codereview.chromium.org/2465723004/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_downloads/item.js:126: return '';
return this.isDangerous_ ? 'cr:warning' : '';

https://codereview.chromium.org/2465723004/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/download/download_item_view.cc (left):

https://codereview.chromium.org/2465723004/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/download/download_item_view.cc:976: kWarningIconSize,
gfx::kGoogleRed700);
can we just use google red everywhere?  it's pretty close

[Jialiu Lin, 2016-11-01 21:06:16]

Patchset #3 (id:40001) has been deleted

[Jialiu Lin, 2016-11-01 21:19:01]

Thanks, dbeam@!
Comments addressed and change vulcanized.
Google red 700 everywhere. :-)

https://codereview.chromium.org/2465723004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_downloads/item.html (right):

https://codereview.chromium.org/2465723004/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_downloads/item.html:116: color: rgb(221, 67, 48);
On 2016/11/01 18:49:50, Dan Beam wrote:
> this similar to --google-red-700 and --paper-deep-orange-800, so maybe we
could
> just use either of those instead?
> 
> if not, you could do something like:
> 
> #danger-icon[icon='cr:warning'],
> .dangerous #description {
>   color: rgb(221, 67, 48);
> }
> 
> or
> 
> :host {
>   --dangerous-color: rgb(221, 67, 48);
> }
> 
> #danger-icon[icon='cr:warning'] {
>   color: var(--dangerous-color);
> }
> 
> /* ... */
> 
> .dangerous #description {
>   color: var(--dangerous-color);
> }

Done.

https://codereview.chromium.org/2465723004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_downloads/item.js (right):

https://codereview.chromium.org/2465723004/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_downloads/item.js:126: return '';
On 2016/11/01 18:49:50, Dan Beam wrote:
> return this.isDangerous_ ? 'cr:warning' : '';

Done.

https://codereview.chromium.org/2465723004/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/download/download_item_view.cc (left):

https://codereview.chromium.org/2465723004/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/download/download_item_view.cc:976: kWarningIconSize,
gfx::kGoogleRed700);
On 2016/11/01 18:49:50, Dan Beam wrote:
> can we just use google red everywhere?  it's pretty close
Agree. I cannot tell the difference between these two reds (though I am not
super sensitive to colors) :-)

[Dan Beam, 2016-11-02 00:52:37]

lgtm

[Jialiu Lin, 2016-11-02 01:20:48]

jialiul@chromium.org changed reviewers:
+ thestig@chromium.org

[Jialiu Lin, 2016-11-02 01:20:48]

thestig@chromium.org: Please review changes in 
 chrome/app/theme/*  and chrome/browser/ui/views/download/download_item_view.cc.

Thanks!

[Lei Zhang, 2016-11-02 05:16:05]

lgtm

[Lei Zhang, 2016-11-02 05:16:10]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 05:16:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 06:28:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 06:28:12]

Dry run: This issue passed the CQ dry run.

[Jialiu Lin, 2016-11-02 17:26:14]

The CQ bit was checked by jialiul@chromium.org

[commit-bot: I haz the power, 2016-11-02 17:26:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 17:35:58]

Committed patchset #3 (id:60001)

[Jialiu Lin, 2016-11-02 17:44:14]

Description was changed from

==========
Make download warning icon and text more consistent

(1) replace previous dangerous warning icons (circle with dash and
  yellow triangle) to red triangles
(2) make the color of this icon consistent on download shelf and
   download page (rgb color DD4330)
(3) make the warning text color consistent with icon color

BUG=657520, 657523
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make download warning icon and text more consistent

(1) replace previous dangerous warning icons (circle with dash and
  yellow triangle) to red triangles
(2) make the color of this icon consistent on download shelf and
   download page (rgb color google-red-700)
(3) make the warning text color consistent with icon color

BUG=657520, 657523
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-02 17:56:38]

Description was changed from

==========
Make download warning icon and text more consistent

(1) replace previous dangerous warning icons (circle with dash and
  yellow triangle) to red triangles
(2) make the color of this icon consistent on download shelf and
   download page (rgb color google-red-700)
(3) make the warning text color consistent with icon color

BUG=657520, 657523
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make download warning icon and text more consistent

(1) replace previous dangerous warning icons (circle with dash and
  yellow triangle) to red triangles
(2) make the color of this icon consistent on download shelf and
   download page (rgb color DD4330)
(3) make the warning text color consistent with icon color

BUG=657520, 657523
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c
Cr-Commit-Position: refs/heads/master@{#429324}
==========

[commit-bot: I haz the power, 2016-11-02 17:56:39]

Patchset 3 (id:??) landed as
https://crrev.com/4a6882854516c760d962aea5924f52fd3c68184c
Cr-Commit-Position: refs/heads/master@{#429324}