Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: chrome/browser/resources/md_downloads/item.js

Issue 2465723004: Make download warning icon and text more consistent (Closed)
Patch Set: address comments and vulcanize Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_downloads/item.js
diff --git a/chrome/browser/resources/md_downloads/item.js b/chrome/browser/resources/md_downloads/item.js
index d87845d1a0ab9a4dd404c5ac67ffba502db0f248..5ef69bfb046b34ea00b9308da7519e354f659fd9 100644
--- a/chrome/browser/resources/md_downloads/item.js
+++ b/chrome/browser/resources/md_downloads/item.js
@@ -121,19 +121,7 @@ cr.define('downloads', function() {
/** @private */
computeDangerIcon_: function() {
- if (!this.isDangerous_)
- return '';
-
- switch (this.data.danger_type) {
- case downloads.DangerType.DANGEROUS_CONTENT:
- case downloads.DangerType.DANGEROUS_HOST:
- case downloads.DangerType.DANGEROUS_URL:
- case downloads.DangerType.POTENTIALLY_UNWANTED:
- case downloads.DangerType.UNCOMMON_CONTENT:
- return 'downloads:remove-circle';
- default:
- return 'cr:warning';
- }
+ return this.isDangerous_ ? 'cr:warning' : '';
},
/** @private */
« no previous file with comments | « chrome/browser/resources/md_downloads/item.html ('k') | chrome/browser/resources/md_downloads/vulcanized.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698