Make download warning icon and text more consistent

chrome/browser/ui/views/download/download_item_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/download/download_item_view.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <vector>
@@ skipping 954 matching lines @@
   dropdown_button_->SetVisible(mode_ == MALICIOUS_MODE);
 }
 
 gfx::ImageSkia DownloadItemView::GetWarningIcon() {
   switch (download()->GetDangerType()) {
     case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_URL:
     case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_CONTENT:
     case content::DOWNLOAD_DANGER_TYPE_UNCOMMON_CONTENT:
     case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_HOST:
     case content::DOWNLOAD_DANGER_TYPE_POTENTIALLY_UNWANTED:
-      return gfx::CreateVectorIcon(gfx::VectorIconId::REMOVE_CIRCLE,
-                                   kWarningIconSize, gfx::kGoogleRed700);

[Dan Beam, 2016/11/01 18:49:50]

can we just use google red everywhere?  it's pretty close

[Jialiu Lin, 2016/11/01 21:19:01]

Agree. I cannot tell the difference between these two reds (though I am not
super sensitive to colors) :-) 

+    case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE:
+      return gfx::CreateVectorIcon(gfx::VectorIconId::WARNING,
+                                   kWarningIconSize,
+                                   gfx::kSafeBrowsingWarningRed);
 
     case content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS:
     case content::DOWNLOAD_DANGER_TYPE_MAYBE_DANGEROUS_CONTENT:
     case content::DOWNLOAD_DANGER_TYPE_USER_VALIDATED:
     case content::DOWNLOAD_DANGER_TYPE_MAX:
       NOTREACHED();
       break;
-
-    case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE:
-      return gfx::CreateVectorIcon(gfx::VectorIconId::WARNING, kWarningIconSize,
-                                   gfx::kGoogleYellow700);
   }
   return gfx::ImageSkia();
 }
 
 gfx::Size DownloadItemView::GetButtonSize() const {
   DCHECK(discard_button_ && (mode_ == MALICIOUS_MODE || save_button_));
   gfx::Size size = discard_button_->GetPreferredSize();
   if (save_button_)
     size.SetToMax(save_button_->GetPreferredSize());
   return size;
@@ skipping 109 matching lines @@
     SchedulePaint();
 }
 
 SkColor DownloadItemView::GetTextColor() const {
   return GetTextColorForThemeProvider(GetThemeProvider());
 }
 
 SkColor DownloadItemView::GetDimmedTextColor() const {
   return SkColorSetA(GetTextColor(), 0xC7);
 }