Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: device/generic_sensor/sensor_provider_impl.cc

Issue 2465363004: [Sensors] Consider maximum supported frequency (Closed)
Patch Set: Comments from Alex Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« device/generic_sensor/platform_sensor_and_provider_unittest_win.cc ('K') | « device/generic_sensor/public/interfaces/sensor_provider.mojom ('k') | third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html » ('j') | third_party/WebKit/Source/modules/sensor/Sensor.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/generic_sensor/sensor_provider_impl.cc
diff --git a/device/generic_sensor/sensor_provider_impl.cc b/device/generic_sensor/sensor_provider_impl.cc
index 8a7860cb1c971d16493ace11b16fe353f1da3dda..7b0a92464a7bb5b41caeae4e5a5e296ef909388e 100644
--- a/device/generic_sensor/sensor_provider_impl.cc
+++ b/device/generic_sensor/sensor_provider_impl.cc
@@ -89,6 +89,13 @@ void SensorProviderImpl::SensorCreated(
init_params->mode = sensor->GetReportingMode();
init_params->default_configuration = sensor->GetDefaultConfiguration();
+ double maximum_frequency = sensor->GetMaximumSupportedFrequency();
+ DCHECK(maximum_frequency);
timvolodine 2016/11/03 17:32:56 >=0?
Mikhail 2016/11/04 21:17:44 The implementation must return a positive value fo
timvolodine 2016/11/09 20:31:52 nit: it could be negative and pass DCHECK?
+ if (maximum_frequency > mojom::SensorConfiguration::kMaxAllowedFrequency)
+ maximum_frequency = mojom::SensorConfiguration::kMaxAllowedFrequency;
+
+ init_params->maximum_frequency = maximum_frequency;
+
NotifySensorCreated(std::move(init_params), sensor_impl->GetClient(),
callback);
« device/generic_sensor/platform_sensor_and_provider_unittest_win.cc ('K') | « device/generic_sensor/public/interfaces/sensor_provider.mojom ('k') | third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html » ('j') | third_party/WebKit/Source/modules/sensor/Sensor.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698