Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2960)

Unified Diff: device/generic_sensor/platform_sensor_and_provider_unittest_win.cc

Issue 2465363004: [Sensors] Consider maximum supported frequency (Closed)
Patch Set: Comments from Alex Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/generic_sensor/platform_sensor_and_provider_unittest_win.cc
diff --git a/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc b/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc
index f0f44bd71c442f3767c5adfb4b824638f4af2bf5..9fc238bb8acb9897f8cf98c33135cfce0c67cbb2 100644
--- a/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc
+++ b/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc
@@ -486,4 +486,22 @@ TEST_F(PlatformSensorAndProviderTestWin, SensorStateChangedToReady) {
base::RunLoop().RunUntilIdle();
}
+// Tests that GetMaximumSupportedFrequency provides correct value.
+TEST_F(PlatformSensorAndProviderTestWin, GetMaximumSupportedFrequency) {
+ SetSupportedReportingFrequency(20);
+ SetSupportedSensor(SENSOR_TYPE_AMBIENT_LIGHT);
+ auto sensor = CreateSensor(SensorType::AMBIENT_LIGHT);
+ EXPECT_TRUE(sensor);
+ EXPECT_THAT(sensor->GetMaximumSupportedFrequency(), 20);
+}
+
+// Tests that GetMaximumSupportedFrequency is returns fallback value.
timvolodine 2016/11/03 17:32:56 -is (think Alexander already mentioned it)
Mikhail 2016/11/04 21:17:44 Done.
+TEST_F(PlatformSensorAndProviderTestWin, GetMaximumSupportedFrequencyFallback) {
+ SetSupportedReportingFrequency(0);
+ SetSupportedSensor(SENSOR_TYPE_AMBIENT_LIGHT);
+ auto sensor = CreateSensor(SensorType::AMBIENT_LIGHT);
+ EXPECT_TRUE(sensor);
+ EXPECT_THAT(sensor->GetMaximumSupportedFrequency(), 5);
+}
+
} // namespace device

Powered by Google App Engine
This is Rietveld 408576698