[Sensors] Consider maximum supported frequency

device/generic_sensor/sensor_provider_impl.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/generic_sensor/sensor_provider_impl.h"
 
 #include <utility>
 
 #include "device/generic_sensor/platform_sensor_provider.h"
 #include "device/generic_sensor/sensor_impl.h"
@@ skipping 71 matching lines @@
   }
 
   auto sensor_impl = base::MakeUnique<SensorImpl>(sensor);
 
   auto init_params = mojom::SensorInitParams::New();
   init_params->memory = std::move(cloned_handle);
   init_params->buffer_offset = SensorReadingSharedBuffer::GetOffset(type);
   init_params->mode = sensor->GetReportingMode();
   init_params->default_configuration = sensor->GetDefaultConfiguration();
 
+  double maximum_frequency = sensor->GetMaximumSupportedFrequency();
+  DCHECK(maximum_frequency);

[Mikhail, 2016/11/04 21:17:44]

The implementation must return a positive value for the frequency limit.

[timvolodine, 2016/11/09 20:31:52]

nit: it could be negative and pass DCHECK?

+  if (maximum_frequency > mojom::SensorConfiguration::kMaxAllowedFrequency)
+    maximum_frequency = mojom::SensorConfiguration::kMaxAllowedFrequency;
+
+  init_params->maximum_frequency = maximum_frequency;
+
   NotifySensorCreated(std::move(init_params), sensor_impl->GetClient(),
                       callback);
 
   mojo::MakeStrongBinding(std::move(sensor_impl), std::move(sensor_request));
 }
 
 }  // namespace device