Removing Variations support for google_update_experiment_id.

Removing Variations support for google_update_experiment_id, and clearing the them from the Google Update experiment labels registry value.

BUG=660934
Committed: https://crrev.com/ab5de4d2557d497cc47b9d4f9b67fc64474ca99f
Cr-Commit-Position: refs/heads/master@{#431623}

[jwd, 2016-10-31 19:43:19]

The CQ bit was checked by jwd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 19:44:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 20:00:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 20:00:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jwd, 2016-10-31 21:10:06]

The CQ bit was checked by jwd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 21:10:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 21:40:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 21:40:37]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[jwd, 2016-11-01 14:36:09]

The CQ bit was checked by jwd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 14:36:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 16:01:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 16:01:56]

Dry run: This issue passed the CQ dry run.

[jwd, 2016-11-02 19:13:47]

The CQ bit was checked by jwd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 19:14:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jwd, 2016-11-02 20:01:39]

The CQ bit was checked by jwd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 20:02:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 21:13:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 21:13:23]

Dry run: This issue passed the CQ dry run.

[jwd, 2016-11-02 22:32:08]

Patchset #1 (id:1) has been deleted

[jwd, 2016-11-02 22:32:20]

Patchset #1 (id:20001) has been deleted

[jwd, 2016-11-02 22:32:33]

Patchset #2 (id:60001) has been deleted

[jwd, 2016-11-02 22:32:41]

Patchset #2 (id:80001) has been deleted

[jwd, 2016-11-02 22:33:53]

Description was changed from

==========
Removing Variations support for google_update_experiment_id.

BUG=660934
==========

to

==========
Removing Variations support for google_update_experiment_id, and clearing the
them from the Google Update experiment labels registry value.

BUG=660934
==========

[jwd, 2016-11-02 22:34:56]

jwd@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-11-03 15:35:26]

asvitkine@chromium.org changed reviewers:
+ rohitrao@chromium.org

[Alexei Svitkine (slow), 2016-11-03 15:35:27]

+rohitrao

I recall iOS having code to also send experiments to Omaha that was using some
of the variations util code. Rohit, do you know if that still exists and needs
to be removed before we can land this?

[Alexei Svitkine (slow), 2016-11-03 17:09:36]

LGTM % comment and assuming Rohit confirms this doesn't break iOS or we clean up
the iOS relevant parts before landing this.

https://codereview.chromium.org/2465003002/diff/120001/chrome/browser/metrics...
File chrome/browser/metrics/variations/chrome_variations_service_client.cc
(right):

https://codereview.chromium.org/2465003002/diff/120001/chrome/browser/metrics...
chrome/browser/metrics/variations/chrome_variations_service_client.cc:146:
FROM_HERE, base::Bind(&ClearGoogleUpdateRegistryLabels));
Previously, it would be started with a delay. Can you keep the delay here?

[jwd, 2016-11-03 22:56:45]

The CQ bit was checked by jwd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 22:58:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 03:07:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 03:07:25]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jwd, 2016-11-04 15:05:15]

https://codereview.chromium.org/2465003002/diff/120001/chrome/browser/metrics...
File chrome/browser/metrics/variations/chrome_variations_service_client.cc
(right):

https://codereview.chromium.org/2465003002/diff/120001/chrome/browser/metrics...
chrome/browser/metrics/variations/chrome_variations_service_client.cc:146:
FROM_HERE, base::Bind(&ClearGoogleUpdateRegistryLabels));
On 2016/11/03 17:09:36, Alexei Svitkine (slow) wrote:
> Previously, it would be started with a delay. Can you keep the delay here?

Done.

[Alexei Svitkine (slow), 2016-11-04 15:27:34]

lgtm % ios

[rohitrao (ping after 24h), 2016-11-08 12:47:30]

Sorry for the delay.  iOS is still using these functions, so I've sent out a CL
to remove our calls.  Is it correct to simply stop sending an "<experiments>"
section in the Omaha ping?

https://codereview.chromium.org/2465003002/diff/140001/components/variations/...
File components/variations/experiment_labels_unittest.cc (right):

https://codereview.chromium.org/2465003002/diff/140001/components/variations/...
components/variations/experiment_labels_unittest.cc:68: // Three no Variotion,
preserving order
Typo: Variation

[Alexei Svitkine (slow), 2016-11-08 17:45:45]

Yep, not sending <experiments> section SGTM - assuming that was the case
before the integration was added and we're not using it for anything else.

On Tue, Nov 8, 2016 at 4:47 AM, <rohitrao@chromium.org> wrote:

> Sorry for the delay. iOS is still using these functions, so I've sent out
> a CL
> to remove our calls. Is it correct to simply stop sending an
> "<experiments>"
> section in the Omaha ping?
>
>
> https://codereview.chromium.org/2465003002/diff/140001/
> components/variations/experiment_labels_unittest.cc
> File components/variations/experiment_labels_unittest.cc (right):
>
> https://codereview.chromium.org/2465003002/diff/140001/
> components/variations/experiment_labels_unittest.cc#newcode68
> components/variations/experiment_labels_unittest.cc:68: // Three no
> Variotion, preserving order
> Typo: Variation
>
> https://codereview.chromium.org/2465003002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[rohitrao (ping after 24h), 2016-11-09 17:40:08]

iOS lgtm now, thanks!

[jwd, 2016-11-09 18:18:54]

jwd@chromium.org changed reviewers:
+ zea@chromium.org

[jwd, 2016-11-09 18:18:54]

+zea@ for sessions_sync_manager_unittest.cc change.

[Nicolas Zea, 2016-11-09 18:37:06]

sync lgtm

[jwd, 2016-11-11 18:53:20]

The CQ bit was checked by jwd@chromium.org

[jwd, 2016-11-11 18:53:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2465003002/#ps160001
(title: "Fix typo.")

[commit-bot: I haz the power, 2016-11-11 18:53:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 20:35:20]

Description was changed from

==========
Removing Variations support for google_update_experiment_id, and clearing the
them from the Google Update experiment labels registry value.

BUG=660934
==========

to

==========
Removing Variations support for google_update_experiment_id, and clearing the
them from the Google Update experiment labels registry value.

BUG=660934
==========

[commit-bot: I haz the power, 2016-11-11 20:35:22]

Committed patchset #5 (id:160001)

[commit-bot: I haz the power, 2016-11-11 21:00:15]

Description was changed from

==========
Removing Variations support for google_update_experiment_id, and clearing the
them from the Google Update experiment labels registry value.

BUG=660934
==========

to

==========
Removing Variations support for google_update_experiment_id, and clearing the
them from the Google Update experiment labels registry value.

BUG=660934

Committed: https://crrev.com/ab5de4d2557d497cc47b9d4f9b67fc64474ca99f
Cr-Commit-Position: refs/heads/master@{#431623}
==========

[commit-bot: I haz the power, 2016-11-11 21:00:17]

Patchset 5 (id:??) landed as
https://crrev.com/ab5de4d2557d497cc47b9d4f9b67fc64474ca99f
Cr-Commit-Position: refs/heads/master@{#431623}