Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: components/variations/variations_associated_data_unittest.cc

Issue 2465003002: Removing Variations support for google_update_experiment_id. (Closed)
Patch Set: Fix typo. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/variations/variations_associated_data_unittest.cc
diff --git a/components/variations/variations_associated_data_unittest.cc b/components/variations/variations_associated_data_unittest.cc
index 5bdd1d8481a2ed47ec4c8c255fac4a62d7ae4235..40ff746d80af811ba504ae662b1efd94eef54bd3 100644
--- a/components/variations/variations_associated_data_unittest.cc
+++ b/components/variations/variations_associated_data_unittest.cc
@@ -180,8 +180,6 @@ TEST_F(VariationsAssociatedDataTest, CollectionsCoexist) {
EXPECT_EQ(EMPTY_ID,
GetIDForTrial(GOOGLE_WEB_PROPERTIES_TRIGGER, trial_true.get()));
EXPECT_EQ(EMPTY_ID,
- GetIDForTrial(GOOGLE_UPDATE_SERVICE, trial_true.get()));
- EXPECT_EQ(EMPTY_ID,
GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get()));
AssociateGoogleVariationID(GOOGLE_WEB_PROPERTIES, trial_true->trial_name(),
@@ -189,17 +187,6 @@ TEST_F(VariationsAssociatedDataTest, CollectionsCoexist) {
EXPECT_EQ(TEST_VALUE_A,
GetIDForTrial(GOOGLE_WEB_PROPERTIES, trial_true.get()));
EXPECT_EQ(EMPTY_ID,
- GetIDForTrial(GOOGLE_UPDATE_SERVICE, trial_true.get()));
- EXPECT_EQ(EMPTY_ID,
- GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get()));
-
- AssociateGoogleVariationID(GOOGLE_UPDATE_SERVICE, trial_true->trial_name(),
- default_name, TEST_VALUE_A);
- EXPECT_EQ(TEST_VALUE_A,
- GetIDForTrial(GOOGLE_WEB_PROPERTIES, trial_true.get()));
- EXPECT_EQ(TEST_VALUE_A,
- GetIDForTrial(GOOGLE_UPDATE_SERVICE, trial_true.get()));
- EXPECT_EQ(EMPTY_ID,
GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get()));
AssociateGoogleVariationID(CHROME_SYNC_SERVICE, trial_true->trial_name(),
@@ -207,8 +194,6 @@ TEST_F(VariationsAssociatedDataTest, CollectionsCoexist) {
EXPECT_EQ(TEST_VALUE_A,
GetIDForTrial(GOOGLE_WEB_PROPERTIES, trial_true.get()));
EXPECT_EQ(TEST_VALUE_A,
- GetIDForTrial(GOOGLE_UPDATE_SERVICE, trial_true.get()));
- EXPECT_EQ(TEST_VALUE_A,
GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get()));
trial_true = CreateFieldTrial("d2", 10, default_name, &default_group_number);
@@ -221,17 +206,6 @@ TEST_F(VariationsAssociatedDataTest, CollectionsCoexist) {
EXPECT_EQ(TEST_VALUE_A,
GetIDForTrial(GOOGLE_WEB_PROPERTIES_TRIGGER, trial_true.get()));
EXPECT_EQ(EMPTY_ID,
- GetIDForTrial(GOOGLE_UPDATE_SERVICE, trial_true.get()));
- EXPECT_EQ(EMPTY_ID,
- GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get()));
-
- AssociateGoogleVariationID(GOOGLE_UPDATE_SERVICE, trial_true->trial_name(),
- default_name, TEST_VALUE_A);
- EXPECT_EQ(TEST_VALUE_A,
- GetIDForTrial(GOOGLE_WEB_PROPERTIES_TRIGGER, trial_true.get()));
- EXPECT_EQ(TEST_VALUE_A,
- GetIDForTrial(GOOGLE_UPDATE_SERVICE, trial_true.get()));
- EXPECT_EQ(EMPTY_ID,
GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get()));
AssociateGoogleVariationID(CHROME_SYNC_SERVICE, trial_true->trial_name(),
@@ -239,8 +213,6 @@ TEST_F(VariationsAssociatedDataTest, CollectionsCoexist) {
EXPECT_EQ(TEST_VALUE_A,
GetIDForTrial(GOOGLE_WEB_PROPERTIES_TRIGGER, trial_true.get()));
EXPECT_EQ(TEST_VALUE_A,
- GetIDForTrial(GOOGLE_UPDATE_SERVICE, trial_true.get()));
- EXPECT_EQ(TEST_VALUE_A,
GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get()));
}
« no previous file with comments | « components/variations/variations_associated_data.cc ('k') | components/variations/variations_seed_processor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698