Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: components/variations/variations_associated_data_unittest.cc

Issue 2465003002: Removing Variations support for google_update_experiment_id. (Closed)
Patch Set: Fix typo. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/variations/variations_associated_data.h" 5 #include "components/variations/variations_associated_data.h"
6 6
7 #include "base/feature_list.h" 7 #include "base/feature_list.h"
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/metrics/field_trial.h" 9 #include "base/metrics/field_trial.h"
10 #include "base/test/scoped_feature_list.h" 10 #include "base/test/scoped_feature_list.h"
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 scoped_refptr<base::FieldTrial> trial_true( 173 scoped_refptr<base::FieldTrial> trial_true(
174 CreateFieldTrial("d1", 10, default_name, &default_group_number)); 174 CreateFieldTrial("d1", 10, default_name, &default_group_number));
175 ASSERT_EQ(default_group_number, trial_true->group()); 175 ASSERT_EQ(default_group_number, trial_true->group());
176 ASSERT_EQ(default_name, trial_true->group_name()); 176 ASSERT_EQ(default_name, trial_true->group_name());
177 177
178 EXPECT_EQ(EMPTY_ID, 178 EXPECT_EQ(EMPTY_ID,
179 GetIDForTrial(GOOGLE_WEB_PROPERTIES, trial_true.get())); 179 GetIDForTrial(GOOGLE_WEB_PROPERTIES, trial_true.get()));
180 EXPECT_EQ(EMPTY_ID, 180 EXPECT_EQ(EMPTY_ID,
181 GetIDForTrial(GOOGLE_WEB_PROPERTIES_TRIGGER, trial_true.get())); 181 GetIDForTrial(GOOGLE_WEB_PROPERTIES_TRIGGER, trial_true.get()));
182 EXPECT_EQ(EMPTY_ID, 182 EXPECT_EQ(EMPTY_ID,
183 GetIDForTrial(GOOGLE_UPDATE_SERVICE, trial_true.get()));
184 EXPECT_EQ(EMPTY_ID,
185 GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get())); 183 GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get()));
186 184
187 AssociateGoogleVariationID(GOOGLE_WEB_PROPERTIES, trial_true->trial_name(), 185 AssociateGoogleVariationID(GOOGLE_WEB_PROPERTIES, trial_true->trial_name(),
188 default_name, TEST_VALUE_A); 186 default_name, TEST_VALUE_A);
189 EXPECT_EQ(TEST_VALUE_A, 187 EXPECT_EQ(TEST_VALUE_A,
190 GetIDForTrial(GOOGLE_WEB_PROPERTIES, trial_true.get())); 188 GetIDForTrial(GOOGLE_WEB_PROPERTIES, trial_true.get()));
191 EXPECT_EQ(EMPTY_ID, 189 EXPECT_EQ(EMPTY_ID,
192 GetIDForTrial(GOOGLE_UPDATE_SERVICE, trial_true.get()));
193 EXPECT_EQ(EMPTY_ID,
194 GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get()));
195
196 AssociateGoogleVariationID(GOOGLE_UPDATE_SERVICE, trial_true->trial_name(),
197 default_name, TEST_VALUE_A);
198 EXPECT_EQ(TEST_VALUE_A,
199 GetIDForTrial(GOOGLE_WEB_PROPERTIES, trial_true.get()));
200 EXPECT_EQ(TEST_VALUE_A,
201 GetIDForTrial(GOOGLE_UPDATE_SERVICE, trial_true.get()));
202 EXPECT_EQ(EMPTY_ID,
203 GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get())); 190 GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get()));
204 191
205 AssociateGoogleVariationID(CHROME_SYNC_SERVICE, trial_true->trial_name(), 192 AssociateGoogleVariationID(CHROME_SYNC_SERVICE, trial_true->trial_name(),
206 default_name, TEST_VALUE_A); 193 default_name, TEST_VALUE_A);
207 EXPECT_EQ(TEST_VALUE_A, 194 EXPECT_EQ(TEST_VALUE_A,
208 GetIDForTrial(GOOGLE_WEB_PROPERTIES, trial_true.get())); 195 GetIDForTrial(GOOGLE_WEB_PROPERTIES, trial_true.get()));
209 EXPECT_EQ(TEST_VALUE_A, 196 EXPECT_EQ(TEST_VALUE_A,
210 GetIDForTrial(GOOGLE_UPDATE_SERVICE, trial_true.get()));
211 EXPECT_EQ(TEST_VALUE_A,
212 GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get())); 197 GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get()));
213 198
214 trial_true = CreateFieldTrial("d2", 10, default_name, &default_group_number); 199 trial_true = CreateFieldTrial("d2", 10, default_name, &default_group_number);
215 ASSERT_EQ(default_group_number, trial_true->group()); 200 ASSERT_EQ(default_group_number, trial_true->group());
216 ASSERT_EQ(default_name, trial_true->group_name()); 201 ASSERT_EQ(default_name, trial_true->group_name());
217 202
218 AssociateGoogleVariationID(GOOGLE_WEB_PROPERTIES_TRIGGER, 203 AssociateGoogleVariationID(GOOGLE_WEB_PROPERTIES_TRIGGER,
219 trial_true->trial_name(), default_name, 204 trial_true->trial_name(), default_name,
220 TEST_VALUE_A); 205 TEST_VALUE_A);
221 EXPECT_EQ(TEST_VALUE_A, 206 EXPECT_EQ(TEST_VALUE_A,
222 GetIDForTrial(GOOGLE_WEB_PROPERTIES_TRIGGER, trial_true.get())); 207 GetIDForTrial(GOOGLE_WEB_PROPERTIES_TRIGGER, trial_true.get()));
223 EXPECT_EQ(EMPTY_ID, 208 EXPECT_EQ(EMPTY_ID,
224 GetIDForTrial(GOOGLE_UPDATE_SERVICE, trial_true.get()));
225 EXPECT_EQ(EMPTY_ID,
226 GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get()));
227
228 AssociateGoogleVariationID(GOOGLE_UPDATE_SERVICE, trial_true->trial_name(),
229 default_name, TEST_VALUE_A);
230 EXPECT_EQ(TEST_VALUE_A,
231 GetIDForTrial(GOOGLE_WEB_PROPERTIES_TRIGGER, trial_true.get()));
232 EXPECT_EQ(TEST_VALUE_A,
233 GetIDForTrial(GOOGLE_UPDATE_SERVICE, trial_true.get()));
234 EXPECT_EQ(EMPTY_ID,
235 GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get())); 209 GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get()));
236 210
237 AssociateGoogleVariationID(CHROME_SYNC_SERVICE, trial_true->trial_name(), 211 AssociateGoogleVariationID(CHROME_SYNC_SERVICE, trial_true->trial_name(),
238 default_name, TEST_VALUE_A); 212 default_name, TEST_VALUE_A);
239 EXPECT_EQ(TEST_VALUE_A, 213 EXPECT_EQ(TEST_VALUE_A,
240 GetIDForTrial(GOOGLE_WEB_PROPERTIES_TRIGGER, trial_true.get())); 214 GetIDForTrial(GOOGLE_WEB_PROPERTIES_TRIGGER, trial_true.get()));
241 EXPECT_EQ(TEST_VALUE_A, 215 EXPECT_EQ(TEST_VALUE_A,
242 GetIDForTrial(GOOGLE_UPDATE_SERVICE, trial_true.get()));
243 EXPECT_EQ(TEST_VALUE_A,
244 GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get())); 216 GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get()));
245 } 217 }
246 218
247 TEST_F(VariationsAssociatedDataTest, AssociateVariationParams) { 219 TEST_F(VariationsAssociatedDataTest, AssociateVariationParams) {
248 const std::string kTrialName = "AssociateVariationParams"; 220 const std::string kTrialName = "AssociateVariationParams";
249 221
250 { 222 {
251 std::map<std::string, std::string> params; 223 std::map<std::string, std::string> params;
252 params["a"] = "10"; 224 params["a"] = "10";
253 params["b"] = "test"; 225 params["b"] = "test";
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 CreateFieldTrial(kTrialName, 100, "A", NULL)); 397 CreateFieldTrial(kTrialName, 100, "A", NULL));
426 398
427 CreateFeatureWithTrial(kFeature, base::FeatureList::OVERRIDE_DISABLE_FEATURE, 399 CreateFeatureWithTrial(kFeature, base::FeatureList::OVERRIDE_DISABLE_FEATURE,
428 trial.get()); 400 trial.get());
429 401
430 std::map<std::string, std::string> actualParams; 402 std::map<std::string, std::string> actualParams;
431 EXPECT_EQ(std::string(), GetVariationParamValueByFeature(kFeature, "x")); 403 EXPECT_EQ(std::string(), GetVariationParamValueByFeature(kFeature, "x"));
432 } 404 }
433 405
434 } // namespace variations 406 } // namespace variations
OLDNEW
« no previous file with comments | « components/variations/variations_associated_data.cc ('k') | components/variations/variations_seed_processor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698