Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by tandrii(chromium) Modified:
4 years, 1 month ago Reviewers:
iannucci, martiniss, Michael Achenbach CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org Target Ref:
refs/heads/master Project:
recipe_engine Visibility:
Public. |
DescriptionDelete tryserver_gerrit and its old properties.
R=martiniss@chromium.org,machenbach@chromium.org
BUG=chromium:645616
Committed: https://github.com/luci/recipes-py/commit/d6020a7ef29d3f7fb77d16a1cd6b32c7b2f09dc2
Patch Set 1 #
Created: 4 years, 1 month ago
Dependent Patchsets: Messages
Total messages: 22 (10 generated)
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
lgtm
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Delete tryserver_gerrit and its old properties. R=martiniss@chromium.org,machenbach@chromium.org BUG=chromium:645616 ========== to ========== Delete tryserver_gerrit and its old properties. R=martiniss@chromium.org,machenbach@chromium.org BUG=chromium:645616 Committed: https://github.com/luci/recipes-py/commit/2ecaa8b5944f016f6bda5cbe93ec6f54e8e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://github.com/luci/recipes-py/commit/2ecaa8b5944f016f6bda5cbe93ec6f54e8e...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2475973003/ by martiniss@chromium.org. The reason for reverting is: broke roll.
Message was sent while issue was closed.
On 2016/11/04 at 22:11:33, martiniss wrote: > A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2475973003/ by martiniss@chromium.org. > > The reason for reverting is: broke roll. https://uberchromegw.corp.google.com/i/internal.infra.cron/builders/recipe-au...
Message was sent while issue was closed.
On 2016/11/04 22:11:33, martiniss wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2475973003/ by mailto:martiniss@chromium.org. > > The reason for reverting is: broke roll. More specifically, there are projects in the build repo that still use it. Please remove the downstream usages of upstream APIs first when removing them, and/or be on hot standby to see that the change gets rolled all the way through (e.g. by submitting followup patches as it rolls down).
Message was sent while issue was closed.
tandrii@chromium.org changed reviewers: + iannucci@chromium.org
Message was sent while issue was closed.
Yep, totally my bad here. I tried to prepare and land all the cleanup CLs downstream first, but I did miss two - depot_tools and build. Btw, maybe roller can send me angry email that my CL broke the roll?
Message was sent while issue was closed.
On 2016/11/05 00:02:19, tandrii(chromium) wrote: > Yep, totally my bad here. > I tried to prepare and land all the cleanup CLs downstream first, but I did miss > two - depot_tools and build. > > Btw, maybe roller can send me angry email that my CL broke the roll? Ah, I see now: I forgot to land this https://codereview.chromium.org/2463653002/ :(
Message was sent while issue was closed.
Description was changed from ========== Delete tryserver_gerrit and its old properties. R=martiniss@chromium.org,machenbach@chromium.org BUG=chromium:645616 Committed: https://github.com/luci/recipes-py/commit/2ecaa8b5944f016f6bda5cbe93ec6f54e8e... ========== to ========== Delete tryserver_gerrit and its old properties. R=martiniss@chromium.org,machenbach@chromium.org BUG=chromium:645616 ==========
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Delete tryserver_gerrit and its old properties. R=martiniss@chromium.org,machenbach@chromium.org BUG=chromium:645616 ========== to ========== Delete tryserver_gerrit and its old properties. R=martiniss@chromium.org,machenbach@chromium.org BUG=chromium:645616 Committed: https://github.com/luci/recipes-py/commit/d6020a7ef29d3f7fb77d16a1cd6b32c7b2f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://github.com/luci/recipes-py/commit/d6020a7ef29d3f7fb77d16a1cd6b32c7b2f... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
