recipe_modules/properties/example.py - Issue 2464673002: Delete tryserver_gerrit and its old properties.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: recipe_modules/properties/example.py

Issue 2464673002: Delete tryserver_gerrit and its old properties. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « recipe_engine/unittests/recipe_api_test.py ('k') | recipe_modules/properties/example.expected/buildbot_tryserver_gerrit_deprecated.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The LUCI Authors. All rights reserved.	1 # Copyright 2014 The LUCI Authors. All rights reserved.

2 # Use of this source code is governed under the Apache License, Version 2.0	2 # Use of this source code is governed under the Apache License, Version 2.0

3 # that can be found in the LICENSE file.	3 # that can be found in the LICENSE file.

4	4

5 from recipe_engine.recipe_api import Property	5 from recipe_engine.recipe_api import Property

6	6

7 DEPS = [	7 DEPS = [

8 'properties',	8 'properties',

9 'step',	9 'step',

10 ]	10 ]

(...skipping 52 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
63 gerrit_project='infra/hidden',	63 gerrit_project='infra/hidden',

64 git_url='https://chrome-internal.googlesource.com/infra/hidden',	64 git_url='https://chrome-internal.googlesource.com/infra/hidden',

65 **pd))	65 **pd))

66 yield (api.test('buildbot_tryserver_gerrit_override_both') +	66 yield (api.test('buildbot_tryserver_gerrit_override_both') +

67 api.properties.tryserver(	67 api.properties.tryserver(

68 gerrit_project='custom',	68 gerrit_project='custom',

69 gerrit_url='https://gerrit.my.host',	69 gerrit_url='https://gerrit.my.host',

70 git_url='https://git.my.host/custom',	70 git_url='https://git.my.host/custom',

71 patch_issue=4455,	71 patch_issue=4455,

72 **pd))	72 **pd))

73 # TODO(tandrii): remove this one. Use the above version instead.

74 yield (api.test('buildbot_tryserver_gerrit_deprecated') +

75 api.properties.tryserver_gerrit(

76 full_project_name='infra/infra',

77 gerrit_host='pdfium-review.googlesource.com',

78 **pd))

OLD	NEW