Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 2465703003: Fix issue overriding bug properties.test_api.tryserver for Gerrit. (Closed)

Created:
4 years, 1 month ago by tandrii(chromium)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M recipe_modules/properties/example.py View 1 chunk +2 lines, -1 line 0 comments Download
M recipe_modules/properties/example.expected/buildbot_tryserver_gerrit_override_both.json View 1 chunk +3 lines, -3 lines 0 comments Download
M recipe_modules/properties/test_api.py View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
tandrii(chromium)
4 years, 1 month ago (2016-10-30 17:03:46 UTC) #1
martiniss
lgtm
4 years, 1 month ago (2016-11-01 00:35:06 UTC) #6
Michael Achenbach
lgtm https://codereview.chromium.org/2465703003/diff/1/recipe_modules/properties/test_api.py File recipe_modules/properties/test_api.py (right): https://codereview.chromium.org/2465703003/diff/1/recipe_modules/properties/test_api.py#newcode89 recipe_modules/properties/test_api.py:89: patch_issue = int(kwargs.pop('issue', kwargs.pop('patch_issue',456789))) nit: space after comma
4 years, 1 month ago (2016-11-01 20:01:13 UTC) #7
tandrii(chromium)
https://codereview.chromium.org/2465703003/diff/1/recipe_modules/properties/test_api.py File recipe_modules/properties/test_api.py (right): https://codereview.chromium.org/2465703003/diff/1/recipe_modules/properties/test_api.py#newcode89 recipe_modules/properties/test_api.py:89: patch_issue = int(kwargs.pop('issue', kwargs.pop('patch_issue',456789))) On 2016/11/01 20:01:13, machenbach (slow) ...
4 years, 1 month ago (2016-11-02 23:23:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465703003/20001
4 years, 1 month ago (2016-11-02 23:24:02 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 23:29:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/recipes-py/commit/2c474706779466f2e18e83a632f6d6debf6...

Powered by Google App Engine
This is Rietveld 408576698