Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2462823002: Deletes dead code. (Closed)

Created:
4 years, 1 month ago by Buck
Modified:
4 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deletes dead code. Deletes additional header passing paths in QUIC, dead as a result of the deprecation of FLAGS_spdy_framer_use_new_methods4. Merge internal change: 136385860 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Updated patchset dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -692 lines) Patch
M net/quic/chromium/quic_chromium_client_stream.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream.cc View 3 chunks +0 lines, -45 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream_test.cc View 13 chunks +41 lines, -91 lines 0 comments Download
M net/quic/chromium/quic_http_stream_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_client_promised_info_test.cc View 10 chunks +15 lines, -21 lines 0 comments Download
M net/quic/core/quic_client_session_base.h View 1 chunk +0 lines, -11 lines 0 comments Download
M net/quic/core/quic_client_session_base.cc View 2 chunks +0 lines, -33 lines 0 comments Download
M net/quic/core/quic_header_list.h View 2 chunks +9 lines, -0 lines 0 comments Download
M net/quic/core/quic_spdy_session.h View 2 chunks +0 lines, -21 lines 0 comments Download
M net/quic/core/quic_spdy_session.cc View 3 chunks +0 lines, -38 lines 0 comments Download
M net/quic/core/quic_spdy_stream.h View 8 chunks +2 lines, -49 lines 0 comments Download
M net/quic/core/quic_spdy_stream.cc View 8 chunks +5 lines, -95 lines 0 comments Download
M net/quic/core/quic_spdy_stream_test.cc View 27 chunks +101 lines, -177 lines 0 comments Download
M net/quic/test_tools/mock_quic_spdy_client_stream.h View 2 chunks +4 lines, -7 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +13 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 3 chunks +10 lines, -23 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_spdy_client_stream.h View 2 chunks +0 lines, -7 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.cc View 2 chunks +0 lines, -48 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 6 chunks +22 lines, -19 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (4 generated)
Buck
4 years, 1 month ago (2016-10-29 04:15:02 UTC) #1
Ryan Hamilton
4 years, 1 month ago (2016-10-29 14:41:39 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698