INPUT element: Updating 'step' attribute should adjust the last value.

INPUT element: Updating 'step' attribute should adjust the last value.

Bug:
If
 - 'step' attribute is updated,
 - we adjust the value, and
 - the value is not dirty,
we adjusted the default value instead of the last value.

Implementation:
We didn't store the last value if the value is not dirty, and compute the value
on the fly.
With this CL, we always store the current value to
HTMLInputElement::m_valueIfDirty though we stored only a dirty value.
 * When |value| attribute is updated, we update m_valueIfDirty as well.
 * Remove special handling of null m_valueIfDirty
  Because setValue(null0string) doesn't clear hasDirtyValue() flag, this CL
  introduces setNonDirtyValue() like HTMLTextAreaElement::setNonDirtyValue().
 * Make HTMLInputElement::value() clearer.

BUG=633074
Committed: https://crrev.com/9763e857c8822745fb03e460e1bafdb638b95d71
Cr-Commit-Position: refs/heads/master@{#428663}

[tkent, 2016-10-31 02:15:56]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 02:16:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-10-31 02:29:31]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 02:29:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-10-31 02:30:48]

Patchset #1 (id:1) has been deleted

[tkent, 2016-10-31 02:32:51]

Description was changed from

==========
INPUT element: Updating 'step' attribute should adjust the last value.

Bug:
When 'step' attribute is updated, we adjust the value, and the value is not
dirty, we adjusted the default value instead of the last value.

Implementation:
We didn't store the last value if the value is not dirty, and compute the value
on the fly.
With this CL, we always store the current value to
HTMLInputElement::m_valueIfDirty though we stored only a dirty value.

BUG=633074
==========

to

==========
INPUT element: Updating 'step' attribute should adjust the last value.

Bug:
If
 - 'step' attribute is updated,
 - we adjust the value, and
 - the value is not dirty,
we adjusted the default value instead of the last value.

Implementation:
We didn't store the last value if the value is not dirty, and compute the value
on the fly.
With this CL, we always store the current value to
HTMLInputElement::m_valueIfDirty though we stored only a dirty value.

BUG=633074
==========

[tkent, 2016-10-31 03:24:19]

Description was changed from

==========
INPUT element: Updating 'step' attribute should adjust the last value.

Bug:
If
 - 'step' attribute is updated,
 - we adjust the value, and
 - the value is not dirty,
we adjusted the default value instead of the last value.

Implementation:
We didn't store the last value if the value is not dirty, and compute the value
on the fly.
With this CL, we always store the current value to
HTMLInputElement::m_valueIfDirty though we stored only a dirty value.

BUG=633074
==========

to

==========
INPUT element: Updating 'step' attribute should adjust the last value.

Bug:
If
 - 'step' attribute is updated,
 - we adjust the value, and
 - the value is not dirty,
we adjusted the default value instead of the last value.

Implementation:
We didn't store the last value if the value is not dirty, and compute the value
on the fly.
With this CL, we always store the current value to
HTMLInputElement::m_valueIfDirty though we stored only a dirty value.
 * When |value| attribute is updated, we update m_valueIfDirty as well.
 * Remove special handling of null m_valueIfDirty
  Because setValue(null string) doesn't clear hasDirtyValue() flag, this CL
  introduced setNonDirtyValue() like HTMLTextAreaElement::setNonDirtyValue().
 * Make HTMLInputElement::value() clearer.

BUG=633074
==========

[commit-bot: I haz the power, 2016-10-31 04:22:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 04:22:46]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-10-31 04:28:52]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2016-10-31 04:28:52]

keishi@, would you review this please?

[keishi, 2016-10-31 07:08:55]

LGTM

[tkent, 2016-10-31 07:13:48]

Description was changed from

==========
INPUT element: Updating 'step' attribute should adjust the last value.

Bug:
If
 - 'step' attribute is updated,
 - we adjust the value, and
 - the value is not dirty,
we adjusted the default value instead of the last value.

Implementation:
We didn't store the last value if the value is not dirty, and compute the value
on the fly.
With this CL, we always store the current value to
HTMLInputElement::m_valueIfDirty though we stored only a dirty value.
 * When |value| attribute is updated, we update m_valueIfDirty as well.
 * Remove special handling of null m_valueIfDirty
  Because setValue(null string) doesn't clear hasDirtyValue() flag, this CL
  introduced setNonDirtyValue() like HTMLTextAreaElement::setNonDirtyValue().
 * Make HTMLInputElement::value() clearer.

BUG=633074
==========

to

==========
INPUT element: Updating 'step' attribute should adjust the last value.

Bug:
If
 - 'step' attribute is updated,
 - we adjust the value, and
 - the value is not dirty,
we adjusted the default value instead of the last value.

Implementation:
We didn't store the last value if the value is not dirty, and compute the value
on the fly.
With this CL, we always store the current value to
HTMLInputElement::m_valueIfDirty though we stored only a dirty value.
 * When |value| attribute is updated, we update m_valueIfDirty as well.
 * Remove special handling of null m_valueIfDirty
  Because setValue(null0string) doesn't clear hasDirtyValue() flag, this CL
  introduces setNonDirtyValue() like HTMLTextAreaElement::setNonDirtyValue().
 * Make HTMLInputElement::value() clearer.

BUG=633074
==========

[tkent, 2016-10-31 07:13:51]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-10-31 07:13:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 07:18:30]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-10-31 07:20:23]

Description was changed from

==========
INPUT element: Updating 'step' attribute should adjust the last value.

Bug:
If
 - 'step' attribute is updated,
 - we adjust the value, and
 - the value is not dirty,
we adjusted the default value instead of the last value.

Implementation:
We didn't store the last value if the value is not dirty, and compute the value
on the fly.
With this CL, we always store the current value to
HTMLInputElement::m_valueIfDirty though we stored only a dirty value.
 * When |value| attribute is updated, we update m_valueIfDirty as well.
 * Remove special handling of null m_valueIfDirty
  Because setValue(null0string) doesn't clear hasDirtyValue() flag, this CL
  introduces setNonDirtyValue() like HTMLTextAreaElement::setNonDirtyValue().
 * Make HTMLInputElement::value() clearer.

BUG=633074
==========

to

==========
INPUT element: Updating 'step' attribute should adjust the last value.

Bug:
If
 - 'step' attribute is updated,
 - we adjust the value, and
 - the value is not dirty,
we adjusted the default value instead of the last value.

Implementation:
We didn't store the last value if the value is not dirty, and compute the value
on the fly.
With this CL, we always store the current value to
HTMLInputElement::m_valueIfDirty though we stored only a dirty value.
 * When |value| attribute is updated, we update m_valueIfDirty as well.
 * Remove special handling of null m_valueIfDirty
  Because setValue(null0string) doesn't clear hasDirtyValue() flag, this CL
  introduces setNonDirtyValue() like HTMLTextAreaElement::setNonDirtyValue().
 * Make HTMLInputElement::value() clearer.

BUG=633074

Committed: https://crrev.com/9763e857c8822745fb03e460e1bafdb638b95d71
Cr-Commit-Position: refs/heads/master@{#428663}
==========

[commit-bot: I haz the power, 2016-10-31 07:20:23]

Patchset 1 (id:??) landed as
https://crrev.com/9763e857c8822745fb03e460e1bafdb638b95d71
Cr-Commit-Position: refs/heads/master@{#428663}