third_party/WebKit/Source/core/html/forms/InputType.h - Issue 2463693002: INPUT element: Updating 'step' attribute should adjust the last value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/InputType.h

Issue 2463693002: INPUT element: Updating 'step' attribute should adjust the last value. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/InputType.h

diff --git a/third_party/WebKit/Source/core/html/forms/InputType.h b/third_party/WebKit/Source/core/html/forms/InputType.h

index 666238e41c4ee12f7d339c941b1c137db18b8176..ca1b864eae91e10f782cdfb541a4ae6c7f768a6e 100644

--- a/third_party/WebKit/Source/core/html/forms/InputType.h

+++ b/third_party/WebKit/Source/core/html/forms/InputType.h

@@ -87,9 +87,9 @@ class CORE_EXPORT InputType : public GarbageCollectedFinalized<InputType> {

// DOM property functions

- // Checked first, before internal storage or the value attribute.

+ // Returns a string value in ValueMode::kFilename.

virtual bool getTypeSpecificValue(String&);

- // Checked last, if both internal storage and value attribute are missing.

+ // TODO(tkent): Remove fallbackValue().

virtual String fallbackValue() const;

// Checked after even fallbackValue, only when the valueWithDefault function

// is called.