Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.h

Issue 2463693002: INPUT element: Updating 'step' attribute should adjust the last value. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLInputElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.h b/third_party/WebKit/Source/core/html/HTMLInputElement.h
index 4fc8a7d0bdce93b4654d2fcb47c70c35d2775943..c3d655425b5a5ce9a66824e500916f82640af754 100644
--- a/third_party/WebKit/Source/core/html/HTMLInputElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.h
@@ -125,6 +125,8 @@ class CORE_EXPORT HTMLInputElement : public HTMLTextFormControlElement {
void setValue(const String&,
TextFieldEventBehavior = DispatchNoEvent) override;
void setValueForUser(const String&);
+ // Update the value, and clear hasDirtyValue() flag.
+ void setNonDirtyValue(const String&);
// Checks if the specified string would be a valid value.
// We should not call this for types with no string value such as CHECKBOX and
// RADIO.
@@ -405,8 +407,8 @@ class CORE_EXPORT HTMLInputElement : public HTMLTextFormControlElement {
bool shouldDispatchFormControlChangeEvent(String&, String&) override;
AtomicString m_name;
- // A dirty value. isNull() means the value is not dirty and we should refer
- // to |value| content attribute value.
+ // The value string in |value| value mode.
+ // TODO(tkent): Rename it to m_nonAttributeValue.
String m_valueIfDirty;
String m_suggestedValue;
int m_size;

Powered by Google App Engine
This is Rietveld 408576698