Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h

Issue 2463293002: [DevTools] migrate InspectorLayerTreeAgent to new style (Closed)
Patch Set: addressed cpmments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h b/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h
index 6f71a23ed95c6d091cf60a517b923d385ca53a71..a1d7406b38148b2c452ff53aca15a841fec622ca 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h
@@ -70,36 +70,29 @@ class CORE_EXPORT InspectorLayerTreeAgent final
void didPaint(const GraphicsLayer*, GraphicsContext&, const LayoutRect&);
// Called from the front-end.
- void enable(ErrorString*) override;
- void disable(ErrorString*) override;
- void compositingReasons(
- ErrorString*,
+ Response enable() override;
+ Response disable() override;
+ Response compositingReasons(
const String& layerId,
std::unique_ptr<protocol::Array<String>>* compositingReasons) override;
- void makeSnapshot(ErrorString*,
- const String& layerId,
- String* snapshotId) override;
- void loadSnapshot(
- ErrorString*,
+ Response makeSnapshot(const String& layerId, String* snapshotId) override;
+ Response loadSnapshot(
std::unique_ptr<protocol::Array<protocol::LayerTree::PictureTile>> tiles,
String* snapshotId) override;
- void releaseSnapshot(ErrorString*, const String& snapshotId) override;
- void profileSnapshot(
- ErrorString*,
+ Response releaseSnapshot(const String& snapshotId) override;
+ Response profileSnapshot(
const String& snapshotId,
- const Maybe<int>& minRepeatCount,
- const Maybe<double>& minDuration,
- const Maybe<protocol::DOM::Rect>& clipRect,
+ Maybe<int> minRepeatCount,
+ Maybe<double> minDuration,
+ Maybe<protocol::DOM::Rect> clipRect,
std::unique_ptr<protocol::Array<protocol::Array<double>>>* timings)
override;
- void replaySnapshot(ErrorString*,
- const String& snapshotId,
- const Maybe<int>& fromStep,
- const Maybe<int>& toStep,
- const Maybe<double>& scale,
- String* dataURL) override;
- void snapshotCommandLog(
- ErrorString*,
+ Response replaySnapshot(const String& snapshotId,
+ Maybe<int> fromStep,
+ Maybe<int> toStep,
+ Maybe<double> scale,
+ String* dataURL) override;
+ Response snapshotCommandLog(
const String& snapshotId,
std::unique_ptr<protocol::Array<protocol::DictionaryValue>>* commandLog)
override;
@@ -115,8 +108,8 @@ class CORE_EXPORT InspectorLayerTreeAgent final
GraphicsLayer* rootGraphicsLayer();
PaintLayerCompositor* paintLayerCompositor();
- GraphicsLayer* layerById(ErrorString*, const String& layerId);
- const PictureSnapshot* snapshotById(ErrorString*, const String& snapshotId);
+ Response layerById(const String& layerId, GraphicsLayer*&);
+ Response snapshotById(const String& snapshotId, const PictureSnapshot*&);
typedef HashMap<int, int> LayerIdToNodeIdMap;
void buildLayerIdToNodeIdMap(PaintLayer*, LayerIdToNodeIdMap&);
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698