Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2463093003: Landing Recent QUIC changes until Sat Oct 29 14:59:35. (Closed)

Created:
4 years, 1 month ago by danzh1
Modified:
4 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until Sat Oct 29 14:59:35. Remove unused QuicTags. No functional change. Merge internal change: 137601502 https://codereview.chromium.org/2470473002/ Add ENDPOINT to a QuicSession DLOG output. n/a (debug log) Merge internal change: 137547744 https://codereview.chromium.org/2468663002/ Make QuicTestClient::response_headers() return a SPDY header block, not BalsaHeaders. n/a - test only Merge internal change: 137425616 https://codereview.chromium.org/2466493003/ public relnote: Add comment of quic async signing. Merge internal change: 137415929 https://codereview.chromium.org/2464983002/ Add explicit != nullptr check in quic_session. No behavior change. Merge internal change: 137192395 https://codereview.chromium.org/2459293003/ Add missing plumbing of ProofSource::Details in some QUIC codepaths This CL adds a bit of code for moving ProofSource::Details objects through the codepaths for evaluating CHLOs. Such an object is produced by ProofSource::GetProof calls in three places: QuicCryptoServerConfig::{ValidateClientHello, ProcessClientHello, BuildServerConfigUpdateMessage}. When a CHLO is evaluated, both ValidateClientHello and ProcessClientHello are called, but the code is structured so that only one of these will make the call to GetProof. But it is possible for the first call not to call GetProof, and for the second to call it instead. In this case, the ProofSource::Details will get dropped on the floor. This issue was not detected in testing because in practice, apparently the first call always invokes GetProof. This change is therefore mostly for completeness and future-proofing. Additional plumbing for stats propagation in QUIC code. Mostly protected by existing flag --enable_async_get_proof. Merge internal change: 137148536 https://codereview.chromium.org/2467563002/ Add connection_options argument to ProofSource::GetProof This CL adds a new argument to both overloads of ProofSource::GetProof, permitting connection_options to be passed in. Currently the ProofSource ignores these arguments, but they will be employed shortly for passing information about Mentat experiments. Added connection_options arguments to ProofSource::GetProof, currently unused. No functional change intended, not flag-protected. Merge internal change: 137083335 https://codereview.chromium.org/2461333003/ n/a (style-only change) Merge internal change: 137066933 https://codereview.chromium.org/2465933002/ Remove unused argument from CryptoTestUtils::SetupCryptoServerConfigForTest n/a test changes only Merge internal change: 137044096 https://codereview.chromium.org/2459283003/ R=rch@chromium.org BUG= Committed: https://crrev.com/1222a443b7eea9676c3102902c5fc3d9f90eba89 Cr-Commit-Position: refs/heads/master@{#429274}

Patch Set 1 #

Patch Set 2 : add changes to /quartc #

Patch Set 3 : add change to quiartc_session_test.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -150 lines) Patch
M net/quic/chromium/crypto/proof_source_chromium.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/chromium/crypto/proof_source_chromium.cc View 2 chunks +14 lines, -10 lines 0 comments Download
M net/quic/chromium/crypto/proof_test_chromium.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M net/quic/core/crypto/crypto_protocol.h View 2 chunks +0 lines, -3 lines 0 comments Download
M net/quic/core/crypto/crypto_server_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/crypto/proof_source.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.h View 4 chunks +8 lines, -5 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 14 chunks +55 lines, -26 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_crypto_server_stream.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/quic_crypto_server_stream.cc View 7 chunks +20 lines, -9 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream_test.cc View 3 chunks +3 lines, -1 line 0 comments Download
M net/quic/core/quic_multipath_received_packet_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/core/quic_session.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/quartc/quartc_session.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/quartc/quartc_session_test.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/fake_proof_source.h View 4 chunks +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/fake_proof_source.cc View 5 chunks +15 lines, -9 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 34 chunks +38 lines, -38 lines 0 comments Download
M net/tools/quic/stateless_rejector.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 3 chunks +2 lines, -5 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 4 chunks +5 lines, -15 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (17 generated)
danzh1
4 years, 1 month ago (2016-10-31 19:42:28 UTC) #1
Ryan Hamilton
lgtm you're a merge machine today!
4 years, 1 month ago (2016-10-31 19:54:01 UTC) #6
danzh1
On 2016/10/31 19:54:01, Ryan Hamilton wrote: > lgtm > > you're a merge machine today! ...
4 years, 1 month ago (2016-11-02 13:46:03 UTC) #17
Ryan Hamilton
lgtm
4 years, 1 month ago (2016-11-02 14:23:42 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463093003/40001
4 years, 1 month ago (2016-11-02 14:23:55 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-02 14:29:26 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 14:33:20 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1222a443b7eea9676c3102902c5fc3d9f90eba89
Cr-Commit-Position: refs/heads/master@{#429274}

Powered by Google App Engine
This is Rietveld 408576698