Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2467563002: Add missing plumbing of ProofSource::Details in some QUIC codepaths (Closed)

Created:
4 years, 1 month ago by danzh1
Modified:
4 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing plumbing of ProofSource::Details in some QUIC codepaths This CL adds a bit of code for moving ProofSource::Details objects through the codepaths for evaluating CHLOs. Such an object is produced by ProofSource::GetProof calls in three places: QuicCryptoServerConfig::{ValidateClientHello, ProcessClientHello, BuildServerConfigUpdateMessage}. When a CHLO is evaluated, both ValidateClientHello and ProcessClientHello are called, but the code is structured so that only one of these will make the call to GetProof. But it is possible for the first call not to call GetProof, and for the second to call it instead. In this case, the ProofSource::Details will get dropped on the floor. This issue was not detected in testing because in practice, apparently the first call always invokes GetProof. This change is therefore mostly for completeness and future-proofing. Additional plumbing for stats propagation in QUIC code. Mostly protected by existing flag --enable_async_get_proof. Merge internal change: 137148536 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -36 lines) Patch
M net/quic/core/crypto/crypto_server_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.h View 2 chunks +6 lines, -5 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 5 chunks +21 lines, -14 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/quic_crypto_server_stream.cc View 4 chunks +11 lines, -8 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/crypto_test_utils_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/stateless_rejector.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
danzh1
4 years, 1 month ago (2016-10-31 18:16:24 UTC) #1
Ryan Hamilton
4 years, 1 month ago (2016-10-31 18:27:37 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698