Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 2461333003: Add connection_options argument to ProofSource::GetProof (Closed)

Created:
4 years, 1 month ago by danzh1
Modified:
4 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add connection_options argument to ProofSource::GetProof This CL adds a new argument to both overloads of ProofSource::GetProof, permitting connection_options to be passed in. Currently the ProofSource ignores these arguments, but they will be employed shortly for passing information about Mentat experiments. Added connection_options arguments to ProofSource::GetProof, currently unused. No functional change intended, not flag-protected. Merge internal change: 137083335 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -41 lines) Patch
M net/quic/chromium/crypto/proof_source_chromium.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/chromium/crypto/proof_source_chromium.cc View 2 chunks +14 lines, -10 lines 0 comments Download
M net/quic/chromium/crypto/proof_test_chromium.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M net/quic/core/crypto/proof_source.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 9 chunks +27 lines, -12 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.cc View 3 chunks +9 lines, -1 line 0 comments Download
M net/quic/core/quic_crypto_server_stream_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/fake_proof_source.h View 4 chunks +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/fake_proof_source.cc View 5 chunks +15 lines, -9 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (4 generated)
danzh1
4 years, 1 month ago (2016-10-31 17:47:29 UTC) #1
Ryan Hamilton
4 years, 1 month ago (2016-10-31 18:28:00 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698