Assume SchemeRegistry only operates on lowercase schemes

Assume SchemeRegistry only operates on lowercase schemes

In particular, this patch removes the CaseFoldingHash from the scheme
lists / map types.

BUG=348655
Committed: https://crrev.com/fca2cb69a52f34820012ae7a730137ec3df047d8
Cr-Commit-Position: refs/heads/master@{#429575}

[Charlie Harrison, 2016-10-30 20:06:39]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-30 20:06:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-30 21:17:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-30 21:17:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Charlie Harrison, 2016-10-30 21:34:23]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-30 21:34:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-30 22:52:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-30 22:52:53]

Dry run: This issue passed the CQ dry run.

[Charlie Harrison, 2016-10-31 12:36:12]

csharrison@chromium.org changed reviewers:
+ mkwst@chromium.org

[Charlie Harrison, 2016-10-31 12:36:12]

Hey Mike, PTAL. Let me know if the DCHECKing is going a little overboard. I
manually inspected callsites to ensure that schemes were being pulled from
KURLs/SecurityOrigins.

Note: there are some maps that are not populated in the public API. Would you be
okay with me removing the register+remove code and inlining the checks in a
simple if statement? I think the locks and maps are only really needed for the
embedder.

[Mike West, 2016-11-03 13:07:05]

On 2016/10/31 at 12:36:12, csharrison wrote:
> Hey Mike, PTAL. Let me know if the DCHECKing is going a little overboard. I
manually inspected callsites to ensure that schemes were being pulled from
KURLs/SecurityOrigins.

LGTM! I think keeping the DCHECKs in is a good idea for the moment. If we end up
never needing them, we can drop them out, but it's nice documentation of the
requirements.

> Note: there are some maps that are not populated in the public API. Would you
be okay with me removing the register+remove code and inlining the checks in a
simple if statement? I think the locks and maps are only really needed for the
embedder.

I think I'd be fine with that, but please loop kinuko@ in on that CL. She knows
the locking requirements better than I do.

[Charlie Harrison, 2016-11-03 13:08:46]

Will do, thanks for the review!

[Charlie Harrison, 2016-11-03 13:08:51]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2016-11-03 13:09:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 14:36:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-03 14:38:10]

Description was changed from

==========
Assume SchemeRegistry only operates on lowercase schemes

In particular, this patch removes the CaseFoldingHash from the scheme
lists / map types.

BUG=348655
==========

to

==========
Assume SchemeRegistry only operates on lowercase schemes

In particular, this patch removes the CaseFoldingHash from the scheme
lists / map types.

BUG=348655

Committed: https://crrev.com/fca2cb69a52f34820012ae7a730137ec3df047d8
Cr-Commit-Position: refs/heads/master@{#429575}
==========

[commit-bot: I haz the power, 2016-11-03 14:38:12]

Patchset 2 (id:??) landed as
https://crrev.com/fca2cb69a52f34820012ae7a730137ec3df047d8
Cr-Commit-Position: refs/heads/master@{#429575}