Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 2475673003: Clean registering mixed content restricting schemes (Closed)

Created:
4 years, 1 month ago by Charlie Harrison
Modified:
4 years, 1 month ago
Reviewers:
kinuko, Mike West
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean registering mixed content restricting schemes This API is unused, so there is no need for a thread safe map, or even a scheme map at all. BUG=348655 Committed: https://crrev.com/d8274d90b6024e83818afe295feb915f68606dd3 Cr-Commit-Position: refs/heads/master@{#430280}

Patch Set 1 #

Patch Set 2 : Clean registering mixed content restricting schemes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -37 lines) Patch
M third_party/WebKit/Source/platform/weborigin/SchemeRegistry.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp View 2 chunks +1 line, -19 lines 0 comments Download
M third_party/WebKit/Source/web/WebSecurityPolicy.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/public/web/WebSecurityPolicy.h View 1 chunk +0 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (10 generated)
Charlie Harrison
kinuko: PTAL? I would like to do this with the other maps but they are ...
4 years, 1 month ago (2016-11-03 16:23:31 UTC) #4
kinuko
lgtm as much as they're no longer used!
4 years, 1 month ago (2016-11-04 01:44:53 UTC) #7
kinuko
+mkwst for review in Source/web and weborigin in general
4 years, 1 month ago (2016-11-04 01:47:24 UTC) #10
Charlie Harrison
+mkwst, these are the only APIs that are actually unused. Seems like the thread in ...
4 years, 1 month ago (2016-11-04 01:52:32 UTC) #11
Charlie Harrison
heh, kinuko beat me to it :D BTW thanks for the review, kinuko
4 years, 1 month ago (2016-11-04 01:54:27 UTC) #12
Mike West
LGTM, thanks!
4 years, 1 month ago (2016-11-07 09:20:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475673003/20001
4 years, 1 month ago (2016-11-07 12:57:31 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-07 16:04:25 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 16:08:50 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d8274d90b6024e83818afe295feb915f68606dd3
Cr-Commit-Position: refs/heads/master@{#430280}

Powered by Google App Engine
This is Rietveld 408576698