Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: third_party/WebKit/Source/platform/weborigin/SchemeRegistryTest.cpp

Issue 2462893002: Assume SchemeRegistry only operates on lowercase schemes (Closed)
Patch Set: remove assumptions from tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/weborigin/SchemeRegistryTest.cpp
diff --git a/third_party/WebKit/Source/platform/weborigin/SchemeRegistryTest.cpp b/third_party/WebKit/Source/platform/weborigin/SchemeRegistryTest.cpp
index ef9424fcf187bb9078876a5790472c583d382072..ce2e87a73c07d973f665845898eceddf21ec6749 100644
--- a/third_party/WebKit/Source/platform/weborigin/SchemeRegistryTest.cpp
+++ b/third_party/WebKit/Source/platform/weborigin/SchemeRegistryTest.cpp
@@ -10,7 +10,6 @@ namespace blink {
namespace {
const char kTestScheme[] = "test-scheme";
-const char kTestSchemeUppercase[] = "TEST-SCHEME";
const char kTestScheme2[] = "test-scheme-2";
class SchemeRegistryTest : public ::testing::Test {
@@ -24,8 +23,6 @@ TEST_F(SchemeRegistryTest, NoCSPBypass) {
EXPECT_FALSE(
SchemeRegistry::schemeShouldBypassContentSecurityPolicy(kTestScheme));
EXPECT_FALSE(SchemeRegistry::schemeShouldBypassContentSecurityPolicy(
- kTestSchemeUppercase));
- EXPECT_FALSE(SchemeRegistry::schemeShouldBypassContentSecurityPolicy(
kTestScheme, SchemeRegistry::PolicyAreaImage));
}
@@ -35,8 +32,6 @@ TEST_F(SchemeRegistryTest, FullCSPBypass) {
EXPECT_TRUE(
SchemeRegistry::schemeShouldBypassContentSecurityPolicy(kTestScheme));
EXPECT_TRUE(SchemeRegistry::schemeShouldBypassContentSecurityPolicy(
- kTestSchemeUppercase));
- EXPECT_TRUE(SchemeRegistry::schemeShouldBypassContentSecurityPolicy(
kTestScheme, SchemeRegistry::PolicyAreaImage));
EXPECT_FALSE(
SchemeRegistry::schemeShouldBypassContentSecurityPolicy(kTestScheme2));
@@ -49,17 +44,11 @@ TEST_F(SchemeRegistryTest, PartialCSPBypass) {
kTestScheme, SchemeRegistry::PolicyAreaImage);
EXPECT_FALSE(
SchemeRegistry::schemeShouldBypassContentSecurityPolicy(kTestScheme));
- EXPECT_FALSE(SchemeRegistry::schemeShouldBypassContentSecurityPolicy(
- kTestSchemeUppercase));
EXPECT_TRUE(SchemeRegistry::schemeShouldBypassContentSecurityPolicy(
kTestScheme, SchemeRegistry::PolicyAreaImage));
- EXPECT_TRUE(SchemeRegistry::schemeShouldBypassContentSecurityPolicy(
- kTestSchemeUppercase, SchemeRegistry::PolicyAreaImage));
EXPECT_FALSE(SchemeRegistry::schemeShouldBypassContentSecurityPolicy(
kTestScheme, SchemeRegistry::PolicyAreaStyle));
EXPECT_FALSE(SchemeRegistry::schemeShouldBypassContentSecurityPolicy(
- kTestSchemeUppercase, SchemeRegistry::PolicyAreaStyle));
- EXPECT_FALSE(SchemeRegistry::schemeShouldBypassContentSecurityPolicy(
kTestScheme2, SchemeRegistry::PolicyAreaImage));
}
« no previous file with comments | « third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698