Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: net/quic/chromium/quic_chromium_client_stream.cc

Issue 2462823002: Deletes dead code. (Closed)
Patch Set: Updated patchset dependency Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/chromium/quic_chromium_client_stream.cc
diff --git a/net/quic/chromium/quic_chromium_client_stream.cc b/net/quic/chromium/quic_chromium_client_stream.cc
index 5a3d996fb093f1e857d626442b5de31131d8a80a..90e5b05f912f6fe84cb79166124005add49058e7 100644
--- a/net/quic/chromium/quic_chromium_client_stream.cc
+++ b/net/quic/chromium/quic_chromium_client_stream.cc
@@ -38,33 +38,6 @@ QuicChromiumClientStream::~QuicChromiumClientStream() {
delegate_->OnClose();
}
-void QuicChromiumClientStream::OnStreamHeadersComplete(bool fin,
- size_t frame_len) {
- QuicSpdyStream::OnStreamHeadersComplete(fin, frame_len);
- if (decompressed_headers().empty() && !decompressed_trailers().empty()) {
- DCHECK(trailers_decompressed());
- // The delegate will read the trailers via a posted task.
- NotifyDelegateOfHeadersCompleteLater(received_trailers().Clone(),
- frame_len);
- } else {
- DCHECK(!headers_delivered_);
- SpdyHeaderBlock headers;
- SpdyFramer framer(HTTP2);
- size_t headers_len = decompressed_headers().length();
- const char* header_data = decompressed_headers().data();
- if (!framer.ParseHeaderBlockInBuffer(header_data, headers_len, &headers)) {
- DLOG(WARNING) << "Invalid headers";
- Reset(QUIC_BAD_APPLICATION_PAYLOAD);
- return;
- }
- MarkHeadersConsumed(headers_len);
- session_->OnInitialHeadersComplete(id(), headers);
-
- // The delegate will read the headers via a posted task.
- NotifyDelegateOfHeadersCompleteLater(std::move(headers), frame_len);
- }
-}
-
void QuicChromiumClientStream::OnInitialHeadersComplete(
bool fin,
size_t frame_len,
@@ -95,23 +68,6 @@ void QuicChromiumClientStream::OnTrailingHeadersComplete(
NotifyDelegateOfHeadersCompleteLater(received_trailers().Clone(), frame_len);
}
-void QuicChromiumClientStream::OnPromiseHeadersComplete(
- QuicStreamId promised_id,
- size_t frame_len) {
- size_t headers_len = decompressed_headers().length();
- SpdyHeaderBlock headers;
- SpdyFramer framer(HTTP2);
- if (!framer.ParseHeaderBlockInBuffer(decompressed_headers().data(),
- headers_len, &headers)) {
- DLOG(WARNING) << "Invalid headers";
- Reset(QUIC_BAD_APPLICATION_PAYLOAD);
- return;
- }
- MarkHeadersConsumed(headers_len);
-
- session_->HandlePromised(id(), promised_id, headers);
-}
-
void QuicChromiumClientStream::OnPromiseHeaderList(
QuicStreamId promised_id,
size_t frame_len,
@@ -291,7 +247,6 @@ void QuicChromiumClientStream::NotifyDelegateOfHeadersComplete(
return;
// Only mark trailers consumed when we are about to notify delegate.
if (headers_delivered_) {
- MarkTrailersConsumed(decompressed_trailers().length());
MarkTrailersConsumed();
// Post an async task to notify delegate of the FIN flag.
NotifyDelegateOfDataAvailableLater();
« no previous file with comments | « net/quic/chromium/quic_chromium_client_stream.h ('k') | net/quic/chromium/quic_chromium_client_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698