Showing previews UI for Offline Previews

Showing previews UI for Offline Previews

This changes the functionality of is_offline_preview() in
OfflinePageTabHelper to check the provisional information as well.

Additionally, this CL addresses other consumers of this information that
want access to it in DidFinishNavigation. Specifically,
PreviewsPageLoadMetricsObserver will access the is_offline_previews bit
as will PreviewsInfoBarHelper.

This also prevents showing the offline pages snackbar and replaces it
with
the previews infobar. This leaves the Offline omnibox and other UI
features.

This is a re-land of https://codereview.chromium.org/2362033002/

BUG=615564, 649148
TBR=bmcquade

Committed: https://crrev.com/ad9e85d3ae876b9531b7850d120a3f363ea0ad34
Cr-Commit-Position: refs/heads/master@{#428409}

[RyanSturm, 2016-10-28 14:01:49]

Description was changed from

==========
Showing previews UI for Offline Previews

This changes the functionality of is_offline_preview() in
OfflinePageTabHelper to check the provisional information as well.

Additionally, this CL addresses other consumers of this information that
want access to it in DidFinishNavigation. Specifically,
PreviewsPageLoadMetricsObserver will access the is_offline_previews bit
as will PreviewsInfoBarHelper.

This also prevents showing the offline pages snackbar and replaces it
with
the previews infobar. This leaves the Offline omnibox and other UI
features.

BUG=
==========

to

==========
Showing previews UI for Offline Previews

This changes the functionality of is_offline_preview() in
OfflinePageTabHelper to check the provisional information as well.

Additionally, this CL addresses other consumers of this information that
want access to it in DidFinishNavigation. Specifically,
PreviewsPageLoadMetricsObserver will access the is_offline_previews bit
as will PreviewsInfoBarHelper.

This also prevents showing the offline pages snackbar and replaces it
with
the previews infobar. This leaves the Offline omnibox and other UI
features.

This is a re-land of https://codereview.chromium.org/2362033002/

BUG=615564, 649148
==========

[RyanSturm, 2016-10-28 14:07:19]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 14:07:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2016-10-28 14:11:14]

ryansturm@chromium.org changed reviewers:
+ jianli@chromium.org, tbansal@chromium.org

[RyanSturm, 2016-10-28 14:11:15]

jianli: PTAL at the diff from the landed patch
tbansal: PTAL, nothing has changed in previews

I verified locally that this fixes the failures in chrome_public_test_apk on
debug android (obviously by the nature of this bug, it will be flaky since the
bool was either false or true sporadically during these tests).

Thanks.

[tbansal1, 2016-10-28 14:18:00]

lgtm

[commit-bot: I haz the power, 2016-10-28 14:57:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 14:57:13]

Dry run: This issue passed the CQ dry run.

[fgorski, 2016-10-28 16:16:28]

fgorski@chromium.org changed reviewers:
+ fgorski@chromium.org

[fgorski, 2016-10-28 16:16:29]

offline_pages lgtm mod comment.

https://codereview.chromium.org/2462653002/diff/20001/chrome/browser/android/...
File chrome/browser/android/offline_pages/offline_page_tab_helper.cc (right):

https://codereview.chromium.org/2462653002/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/offline_page_tab_helper.cc:182: // TODO:
Change this once offline pages infrastructure uses NavigationHandle
put your ldap next to the TODO(ryan...), please.

[RyanSturm, 2016-10-28 16:19:40]

Description was changed from

==========
Showing previews UI for Offline Previews

This changes the functionality of is_offline_preview() in
OfflinePageTabHelper to check the provisional information as well.

Additionally, this CL addresses other consumers of this information that
want access to it in DidFinishNavigation. Specifically,
PreviewsPageLoadMetricsObserver will access the is_offline_previews bit
as will PreviewsInfoBarHelper.

This also prevents showing the offline pages snackbar and replaces it
with
the previews infobar. This leaves the Offline omnibox and other UI
features.

This is a re-land of https://codereview.chromium.org/2362033002/

BUG=615564, 649148
==========

to

==========
Showing previews UI for Offline Previews

This changes the functionality of is_offline_preview() in
OfflinePageTabHelper to check the provisional information as well.

Additionally, this CL addresses other consumers of this information that
want access to it in DidFinishNavigation. Specifically,
PreviewsPageLoadMetricsObserver will access the is_offline_previews bit
as will PreviewsInfoBarHelper.

This also prevents showing the offline pages snackbar and replaces it
with
the previews infobar. This leaves the Offline omnibox and other UI
features.

This is a re-land of https://codereview.chromium.org/2362033002/

BUG=615564, 649148

TBR=bmcquade
==========

[RyanSturm, 2016-10-28 16:19:40]

ryansturm@chromium.org changed reviewers:
+ bmcquade@chromium.org
- jianli@chromium.org

[RyanSturm, 2016-10-28 16:21:59]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 16:22:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 17:10:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 17:10:49]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2016-10-28 17:22:47]

The CQ bit was checked by ryansturm@chromium.org

[RyanSturm, 2016-10-28 17:22:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
tbansal@chromium.org, fgorski@chromium.org
Link to the patchset: https://codereview.chromium.org/2462653002/#ps40001
(title: "fgorski comment")

[commit-bot: I haz the power, 2016-10-28 17:22:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 17:28:31]

Description was changed from

==========
Showing previews UI for Offline Previews

This changes the functionality of is_offline_preview() in
OfflinePageTabHelper to check the provisional information as well.

Additionally, this CL addresses other consumers of this information that
want access to it in DidFinishNavigation. Specifically,
PreviewsPageLoadMetricsObserver will access the is_offline_previews bit
as will PreviewsInfoBarHelper.

This also prevents showing the offline pages snackbar and replaces it
with
the previews infobar. This leaves the Offline omnibox and other UI
features.

This is a re-land of https://codereview.chromium.org/2362033002/

BUG=615564, 649148

TBR=bmcquade
==========

to

==========
Showing previews UI for Offline Previews

This changes the functionality of is_offline_preview() in
OfflinePageTabHelper to check the provisional information as well.

Additionally, this CL addresses other consumers of this information that
want access to it in DidFinishNavigation. Specifically,
PreviewsPageLoadMetricsObserver will access the is_offline_previews bit
as will PreviewsInfoBarHelper.

This also prevents showing the offline pages snackbar and replaces it
with
the previews infobar. This leaves the Offline omnibox and other UI
features.

This is a re-land of https://codereview.chromium.org/2362033002/

BUG=615564, 649148

TBR=bmcquade
==========

[commit-bot: I haz the power, 2016-10-28 17:28:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-28 17:53:31]

Description was changed from

==========
Showing previews UI for Offline Previews

This changes the functionality of is_offline_preview() in
OfflinePageTabHelper to check the provisional information as well.

Additionally, this CL addresses other consumers of this information that
want access to it in DidFinishNavigation. Specifically,
PreviewsPageLoadMetricsObserver will access the is_offline_previews bit
as will PreviewsInfoBarHelper.

This also prevents showing the offline pages snackbar and replaces it
with
the previews infobar. This leaves the Offline omnibox and other UI
features.

This is a re-land of https://codereview.chromium.org/2362033002/

BUG=615564, 649148

TBR=bmcquade
==========

to

==========
Showing previews UI for Offline Previews

This changes the functionality of is_offline_preview() in
OfflinePageTabHelper to check the provisional information as well.

Additionally, this CL addresses other consumers of this information that
want access to it in DidFinishNavigation. Specifically,
PreviewsPageLoadMetricsObserver will access the is_offline_previews bit
as will PreviewsInfoBarHelper.

This also prevents showing the offline pages snackbar and replaces it
with
the previews infobar. This leaves the Offline omnibox and other UI
features.

This is a re-land of https://codereview.chromium.org/2362033002/

BUG=615564, 649148

TBR=bmcquade

Committed: https://crrev.com/ad9e85d3ae876b9531b7850d120a3f363ea0ad34
Cr-Commit-Position: refs/heads/master@{#428409}
==========

[commit-bot: I haz the power, 2016-10-28 17:53:33]

Patchset 3 (id:??) landed as
https://crrev.com/ad9e85d3ae876b9531b7850d120a3f363ea0ad34
Cr-Commit-Position: refs/heads/master@{#428409}