Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3907)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java

Issue 2462653002: Showing previews UI for Offline Previews (Closed)
Patch Set: fgorski comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java
index 28749599ffd23977b2eb4bb1add408893fcc9f34..e1027e91bc3fd9a2f88705be679365bcd72c72a4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java
@@ -211,23 +211,29 @@ public class OfflinePageTabObserver
@VisibleForTesting
boolean isObservingNetworkChanges() {
return mIsObservingNetworkChanges;
}
@VisibleForTesting
boolean isConnected() {
return OfflinePageUtils.isConnected();
}
+ @VisibleForTesting
+ boolean isShowingOfflinePreview(Tab tab) {
+ return OfflinePageUtils.isShowingOfflinePreview(tab);
+ }
+
void maybeShowReloadSnackbar(Tab tab, boolean isNetworkEvent) {
+ // Exclude Offline Previews, as there is a seperate UI for previews.
if (tab == null || tab.isFrozen() || tab.isHidden() || !tab.isOfflinePage()
- || !isConnected() || !isLoadedTab(tab)
+ || isShowingOfflinePreview(tab) || !isConnected() || !isLoadedTab(tab)
|| (wasSnackbarSeen(tab) && !isNetworkEvent)) {
// Conditions to show a snackbar are not met.
return;
}
showReloadSnackbar(tab);
mObservedTabs.get(tab.getId()).wasSnackbarSeen = true;
}
@VisibleForTesting

Powered by Google App Engine
This is Rietveld 408576698