Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: chrome/browser/android/offline_pages/offline_page_tab_helper.h

Issue 2462653002: Showing previews UI for Offline Previews (Closed)
Patch Set: fgorski comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_tab_helper.h
diff --git a/chrome/browser/android/offline_pages/offline_page_tab_helper.h b/chrome/browser/android/offline_pages/offline_page_tab_helper.h
index 8ded15dff9f73a0f2da25095d9520ed0315bb29d..991857a8b84ba4ee6bfa6d031501026ca9d9671b 100644
--- a/chrome/browser/android/offline_pages/offline_page_tab_helper.h
+++ b/chrome/browser/android/offline_pages/offline_page_tab_helper.h
@@ -35,21 +35,21 @@ class OfflinePageTabHelper :
const OfflinePageItem* offline_page() {
return offline_info_.offline_page.get();
}
const OfflinePageHeader& offline_header() const {
return offline_info_.offline_header;
}
// Whether the page is an offline preview.
- bool is_offline_preview() const { return offline_info_.is_offline_preview; }
+ bool IsShowingOfflinePreview() const;
// Returns provisional offline page since actual navigation does not happen
// during unit tests.
const OfflinePageItem* GetOfflinePageForTest() const;
private:
friend class content::WebContentsUserData<OfflinePageTabHelper>;
// Contains the info about the offline page being loaded.
struct LoadedOfflinePageInfo {
@@ -57,21 +57,21 @@ class OfflinePageTabHelper :
~LoadedOfflinePageInfo();
// The cached copy of OfflinePageItem.
std::unique_ptr<OfflinePageItem> offline_page;
// The offline header that is provided when offline page is loaded.
OfflinePageHeader offline_header;
// Whether the page is an offline preview. Offline page previews are shown
// when a user's effective connection type is prohibitively slow.
- bool is_offline_preview;
+ bool is_showing_offline_preview;
void Clear();
};
explicit OfflinePageTabHelper(content::WebContents* web_contents);
// Overridden from content::WebContentsObserver:
void DidStartNavigation(
content::NavigationHandle* navigation_handle) override;
void DidFinishNavigation(

Powered by Google App Engine
This is Rietveld 408576698