Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2462553002: [heap] Do not wait for marking deque uncommit task on tear down. (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Do not wait for marking deque uncommit task on tear down. Cancelable task already guarantees proper waiting. BUG= Committed: https://crrev.com/e12f9a113afbcc0ce6efcff0a92e224b55b47d30 Cr-Commit-Position: refs/heads/master@{#40647}

Patch Set 1 #

Patch Set 2 : remove more #

Patch Set 3 : fix test #

Patch Set 4 : fix test 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -21 lines) Patch
M src/heap/mark-compact.h View 1 4 chunks +0 lines, -6 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 chunks +1 line, -15 lines 0 comments Download
M test/cctest/heap/test-mark-compact.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
ulan
ptal
4 years, 1 month ago (2016-10-28 09:49:59 UTC) #4
Michael Lippautz
lgtm
4 years, 1 month ago (2016-10-28 09:53:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462553002/20001
4 years, 1 month ago (2016-10-28 09:54:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/15368) v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-10-28 10:14:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462553002/40001
4 years, 1 month ago (2016-10-28 12:24:52 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/11315) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-10-28 12:46:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462553002/60001
4 years, 1 month ago (2016-10-28 13:26:06 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-28 13:52:22 UTC) #18
Michael Achenbach
Note also these flaky races: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/12470/steps/Check%20-%20extra%20%28flakes%29/logs/HiddenProperties https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/12472/steps/Check%20-%20extra%20%28flakes%29/logs/regress-crbug-506443 May have stared before this CL.
4 years, 1 month ago (2016-10-28 17:44:56 UTC) #19
Michael Achenbach
Yea, the problem seems much older. Found this similar flake: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/12387/steps/Check%20-%20extra%20%28flakes%29/logs/regress-crbug-506443
4 years, 1 month ago (2016-10-28 18:45:42 UTC) #20
Michael Achenbach
Filed https://bugs.chromium.org/p/v8/issues/detail?id=5583
4 years, 1 month ago (2016-10-28 18:50:27 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:16:52 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e12f9a113afbcc0ce6efcff0a92e224b55b47d30
Cr-Commit-Position: refs/heads/master@{#40647}

Powered by Google App Engine
This is Rietveld 408576698