Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: src/heap/mark-compact.h

Issue 2462553002: [heap] Do not wait for marking deque uncommit task on tear down. (Closed)
Patch Set: fix test 2 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/mark-compact.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/mark-compact.h
diff --git a/src/heap/mark-compact.h b/src/heap/mark-compact.h
index 9750083ffeb28d9e5351b2c143a1785407d66e9a..7e94ee54cfc70eeb22fdfc375764bdaf04c88c54 100644
--- a/src/heap/mark-compact.h
+++ b/src/heap/mark-compact.h
@@ -64,7 +64,6 @@ class MarkingDeque {
overflowed_(false),
in_use_(false),
uncommit_task_pending_(false),
- uncommit_task_id_(0),
heap_(heap) {}
void SetUp();
@@ -144,7 +143,6 @@ class MarkingDeque {
marking_deque_->Uncommit();
}
marking_deque_->uncommit_task_pending_ = false;
- marking_deque_->uncommit_task_barrier_.NotifyOne();
}
MarkingDeque* marking_deque_;
@@ -163,10 +161,7 @@ class MarkingDeque {
// Must be called with mutex lock.
void StartUncommitTask();
- void CancelOrWaitForUncommitTask();
-
base::Mutex mutex_;
- base::ConditionVariable uncommit_task_barrier_;
base::VirtualMemory* backing_store_;
size_t backing_store_committed_size_;
@@ -182,7 +177,6 @@ class MarkingDeque {
// committed and will stay committed at least until in_use_ == false.
bool in_use_;
bool uncommit_task_pending_;
- uint32_t uncommit_task_id_;
Heap* heap_;
DISALLOW_COPY_AND_ASSIGN(MarkingDeque);
« no previous file with comments | « no previous file | src/heap/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698